Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallets menu item is present on official builds #5383

Closed
ryanml opened this issue Jul 25, 2019 · 1 comment · Fixed by brave/brave-core#3006
Closed

Crypto Wallets menu item is present on official builds #5383

ryanml opened this issue Jul 25, 2019 · 1 comment · Fixed by brave/brave-core#3006

Comments

@ryanml
Copy link
Contributor

ryanml commented Jul 25, 2019

In the settings toolbar, It should only be in unofficial builds for now, to match brave_wallet_enabled

  1. In official build, navigate to brave://settings

Expected Behavior

  1. Crypto Wallets menu item is not present

Actual Behavior

  1. Crypto Wallets menu item is present and leads to missing page
@kjozwiak
Copy link
Member

kjozwiak commented Sep 30, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured that Crypto Wallets appeared under brave://settings without any issues
  • ensured that clicking on Crypto Wallets opened brave://wallets on new profiles without issues

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that Crypto Wallets appeared under brave://settings without any issues
  • ensured that clicking on Crypto Wallets opened brave://wallets on new profiles without issues

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS
  • ensured that Crypto Wallets appeared under brave://settings without any issues
  • ensured that clicking on Crypto Wallets opened brave://wallets on new profiles without issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment