Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimated pending rewards drops to 0 after tokens redeemed #5390

Closed
LaurenWags opened this issue Jul 25, 2019 · 4 comments
Closed

Estimated pending rewards drops to 0 after tokens redeemed #5390

LaurenWags opened this issue Jul 25, 2019 · 4 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #5175

Estimated pending rewards dropped to 0 after tokens were redeemed on the server.

Steps to Reproduce

  1. Start from a clean profile and trigger an ad
  2. Quit the browser.
  3. Go to something like https://www.unixtimestamp.com/ and find a timestamp a couple of minutes from now
  4. Under Default/rewards_service/confirmations.json change the field "next_token_redemption_date_in_seconds" to have that new time. This will force a payment token cash in sooner.
  5. Start the browser back up and wait until after the timestamp
  6. If you have Rewards page open, note that your estimated pending rewards doesn't change once tokens are cashed in.
  7. Refresh Rewards page.

Actual result:

Estimated pending rewards gets reset to 0

Expected result:

Estimated pending rewards should not get reset to 0

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@GeetaSarvadnya
Copy link

The issue is Reproducible on Windows 10 x64

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

@LaurenWags
Copy link
Member Author

Added milestone and assignment per discussion with @jsecretan and @tmancey - if needed please adjust these.

cc @kjozwiak

@LaurenWags
Copy link
Member Author

Should be solved by #5011 . We need to recheck this issue once uplift of #5011 is complete.

@LaurenWags
Copy link
Member Author

LaurenWags commented Jul 28, 2019

Verified passed with

Brave 0.67.119 Chromium: 76.0.3809.72 (Official Build) (64-bit)
Revision 5a04c669126f657f98824b436555cae41b8f4146-refs/branch-heads/3809@{#897}
OS Mac OS X
  • Verified STR in description

Verification passed on

Brave 0.67.119 Chromium: 76.0.3809.72 (Official Build) (64-bit)
Revision 5a04c669126f657f98824b436555cae41b8f4146-refs/branch-heads/3809@{#897}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR mentioned in the description

Verification passed on

Brave 0.67.119 Chromium: 76.0.3809.72 (Official Build) (64-bit)
Revision 5a04c669126f657f98824b436555cae41b8f4146-refs/branch-heads/3809@{#897}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants