Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed payment balances do not retry unless browser is restarted or ad grant is claimed #5175

Closed
tmancey opened this issue Jul 8, 2019 · 1 comment · Fixed by brave/brave-core#2878

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 8, 2019

Description

Failed payment balances fail to retry unless browser is restarted or ad grant is claimed

Steps to Reproduce

  1. Disconnect network connection
  2. Launch browser
  3. Wait 10 minutes

an additional test case is:

  1. Start from a clean profile and trigger an ad
  2. Quit the browser.
  3. Go to something like https://www.unixtimestamp.com/ and find a timestamp a couple of minutes from now
  4. Under Default/rewards_service/confirmations.json change the field "next_token_redemption_date_in_seconds" to have that new time. This will force a payment token cash in sooner.
  5. Start the browser back up and wait until after the timestamp
  6. In the broken version, the the "Estimated pending rewards" goes down to 0. In the fixed version, it should be non zero.

Actual result:

Log shows "Start retrying in # seconds", and after # seconds have passed GetPaymentBalance should be retried however the retry is cancelled and then restarted without retrying to get the payment balance.

Expected result:

Log shows "Start retrying in # seconds", and after # seconds have passed GetPaymentBalance should be shown in the log. You can re-connect the network connection to make sure the payment balance is retrieved.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Workaround is to restart the browser or wait until a user claims an ad grant

@tmancey tmancey self-assigned this Jul 8, 2019
@tmancey tmancey added this to the 0.69.x - Nightly milestone Jul 8, 2019
@tmancey tmancey changed the title Failed payment balances fail to retry unless browser is restarted or ad grant is claimed Failed payment balances do not retry unless browser is restarted or ad grant is claimed Jul 8, 2019
@tmancey tmancey added the QA/Yes label Jul 8, 2019
tmancey added a commit to brave/brave-core that referenced this issue Jul 23, 2019
tmancey added a commit to brave/brave-core that referenced this issue Jul 23, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jul 25, 2019

Verified passed with

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Verification passed on

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

tmancey pushed a commit that referenced this issue Apr 9, 2020
tmancey pushed a commit that referenced this issue Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment