logic for shield settings is located in multiple places and none of them are shareable with android

[bridiver]

Shields setting logic needs to be consolidated so it is consistent everywhere

[bridiver]

QA - this affects all shield settings for both defaults and site settings. Extensive unit tests have been added, but it still needs a pass for all settings.

[btlechowski]

Verification passed on

Brave	0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Ubuntu 18.04 LTS

Verified Bravery settings and Fingerprint Tests from our manual testrun

Shields Panel

• verified turning on/off shields works
• verified https upgrading works
• verified ads and trackers blocking
• verified script blocking
• verified cookies blocking
• verified fingerprint protection
• verified simple and advanced view
• verified that the settings are retained after browser restart
• verified that the settings are retained after closing and reopening the page

NTP stats

• verified ads and trackers blocked stats are increasing
• verified https upgrade stats are increasing
• verified that the stats are retained after browser restart.

Global Shields Settings

• verified https upgrading works
• verified ads and trackers blocking
• verified script blocking
• verified cookies blocking
• verified fingerprint protection
• verified toggling simple and advance view works
• verified that the settings are retained after browser restart

Verified following Upgrade scenarios from 0.68.141

• NTP stats are retained
• Shields Panel settings are retained
• Global Shields Settings are retained

Verification passed on

Brave	0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified Bravery settings and Fingerprint Tests from our manual testrun

Shields Panel

• verified turning on/off shields works
• verified https upgrading works
• verified ads and trackers blocking
• verified script blocking
• verified cookies blocking
• verified fingerprint protection
• verified simple and advanced view
• verified that the settings are retained after browser restart
• verified that the settings are retained after closing and reopening the page

NTP stats

• verified ads and trackers blocked stats are increasing
• verified https upgrade stats are increasing
• verified that the stats are retained after browser restart.

Global Shields Settings

• verified https upgrading works
• verified ads and trackers blocking
• verified script blocking
• verified cookies blocking
• verified fingerprint protection
• verified toggling simple and advance view works
• verified that the settings are retained after browser restart

Verified following Upgrade scenarios from 0.68.141

• NTP stats are retained
• Shields Panel settings are retained
• Global Shields Settings are retained

Verified passed with

Brave	0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	macOS Version 10.13.6 (Build 17G5019)

Shields Panel

• verified turning on/off shields works
• verified https upgrading works
• verified ads and trackers blocking
• verified script blocking
• verified cookies blocking
• verified fingerprint protection
• verified simple and advanced view
• verified that the settings are retained after browser restart
• verified that the settings are retained after closing and reopening the page

NTP stats

• verified ads and trackers blocked stats are increasing
• verified https upgrade stats are increasing
• verified that the stats are retained after browser restart.

Global Shields Settings

• verified https upgrading works
• verified ads and trackers blocking
• verified script blocking
• verified cookies blocking
• verified fingerprint protection
• verified toggling simple and advance view works
• verified that the settings are retained after browser restart

Verified following Upgrade scenarios from 0.68.141

• NTP stats are retained
• Shields Panel settings are retained
• Global Shields Settings are retained

• Additionally Bravery settings and Fingerprint Tests from manual test run were completed by @kjozwiak