Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve accessibility on welcome experience #5504

Closed
rossmoody opened this issue Aug 1, 2019 · 1 comment · Fixed by brave/brave-core#3300
Closed

improve accessibility on welcome experience #5504

rossmoody opened this issue Aug 1, 2019 · 1 comment · Fixed by brave/brave-core#3300
Assignees
@cezaraugusto
Labels
about-pages/welcome accessibility design A design change, especially one which needs input from the design team priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.1.x - Release

Comments

@rossmoody
Copy link
Contributor

Description

Tabbing currently prompts some pretty odd formatting and behavior bugs. I didn't deep dive into the causes or solves but it looks like you can tab through all the slides at once. Would be nice to give each interactive element a tab index and limit it to what's visible on the page.

Steps to Reproduce

  1. go to brave://welcome on nightly
  2. Press tab 4-7 times
  3. Behold
@bsclifton bsclifton added about-pages/welcome accessibility design A design change, especially one which needs input from the design team labels Aug 2, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Aug 9, 2019
@rossmoody rossmoody mentioned this issue Aug 28, 2019
Closed
cezaraugusto added a commit to brave/brave-core that referenced this issue Aug 29, 2019
@cezaraugusto
Allow navigation via tab key in welcome page
7295cda 
fix brave/brave-browser#5504

Welcome page navigation via tab is impossible without this change
since all non-visible content is hidden visually but still accessible
via keyboard. This change fixes it and improves other element focus.
@cezaraugusto cezaraugusto mentioned this issue Aug 29, 2019
Merged
6 tasks
bsclifton pushed a commit to brave/brave-core that referenced this issue Oct 1, 2019
@cezaraugusto @bsclifton
Allow navigation via tab key in welcome page
5747a8c 
fix brave/brave-browser#5504

Welcome page navigation via tab is impossible without this change
since all non-visible content is hidden visually but still accessible
via keyboard. This change fixes it and improves other element focus.
cezaraugusto added a commit to brave/brave-core that referenced this issue Oct 4, 2019
@cezaraugusto
Allow navigation via tab key in welcome page
3f767d4 
fix brave/brave-browser#5504

Welcome page navigation via tab is impossible without this change
since all non-visible content is hidden visually but still accessible
via keyboard. This change fixes it and improves other element focus.
bsclifton pushed a commit to brave/brave-core that referenced this issue Oct 8, 2019
@cezaraugusto @bsclifton
Allow navigation via tab key in welcome page
0a6d4bc 
fix brave/brave-browser#5504

Welcome page navigation via tab is impossible without this change
since all non-visible content is hidden visually but still accessible
via keyboard. This change fixes it and improves other element focus.
@bsclifton bsclifton added this to the 0.72.x - Nightly milestone Oct 8, 2019
@btlechowski
Copy link

btlechowski commented Nov 15, 2019 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3300
Tab now jumps around select-able elements.

Verified passed with

Brave 1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Verification passed on

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@LaurenWags LaurenWags mentioned this issue Nov 15, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
about-pages/welcome accessibility design A design change, especially one which needs input from the design team priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging a pull request may close this issue.

Allow navigation via tab key in welcome page brave/brave-core
7 participants
@cezaraugusto @bsclifton @rebron @LaurenWags @rossmoody @btlechowski @GeetaSarvadnya