Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People / Profile menu shows Sync status #5839

Closed
bsclifton opened this issue Aug 29, 2019 · 5 comments · Fixed by brave/brave-core#3357
Closed

People / Profile menu shows Sync status #5839

bsclifton opened this issue Aug 29, 2019 · 5 comments · Fixed by brave/brave-core#3357

Comments

@bsclifton
Copy link
Member

Description

Starting with 0.69.x, the People menu is broken. It's showing Sync status:
image

Steps to Reproduce

  1. Download 0.69.x, 0.70.x, or 0.71.x
  2. If on 0.70.x or 0.71.x, you'll need to create a new profile first
  3. Click the person icon (next to hamburger) and you'll see problem (see pic above)

Actual result:

image

Expected result:

Screen Shot 2019-08-29 at 3 36 17 PM

Reproduces how often:

100%

Brave version (brave://version info)

0.69.x and newer

Version/Channel Information:

  • Can you reproduce this issue with the current release? N
  • Can you reproduce this issue with the beta channel? Y
  • Can you reproduce this issue with the dev channel? Y
  • Can you reproduce this issue with the nightly channel? Y

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 30, 2019
@petemill
Copy link
Member

petemill commented Aug 30, 2019

What is this meant to show before this error started showing up - does it ever show our sync status, or does it / should it never show anything ever to do with sync @rebron @bsclifton @darkdh?

@rebron
Copy link
Collaborator

rebron commented Aug 30, 2019

We shouldn't show the sync section at all here.

@bsclifton
Copy link
Member Author

Link to PR where sync was originally removed:
brave/brave-core#1035

@bsclifton
Copy link
Member Author

Yikes - I wonder if this is related to #5849 ?

@LaurenWags
Copy link
Member

LaurenWags commented Sep 9, 2019

Verified passed with

Brave 0.69.125 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified STR from description
    Screen Shot 2019-09-09 at 4 45 28 PM

Verification passed on

Brave 0.69.125 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified STR from description
    image

Verification passed on

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants