Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: never show service error status in browser UI (uplift to 0.71.x) #3366

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Sync: never show service error status in browser UI (uplift to 0.71.x) #3366

merged 1 commit into from
Sep 6, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 5, 2019 •
edited by bsclifton
Loading

Uplift of #3357
Fixes brave/brave-browser#5839

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Sep 5, 2019
@brave-builds brave-builds added this to the 0.71.x - Dev milestone Sep 5, 2019
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv September 5, 2019 16:04
bsclifton
bsclifton approved these changes Sep 6, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as 0.69.x and 0.70.x have already been approved; CI looks great here. For some reason, travis-ci is hung? but if you visit, all items are green. Good to go!

@bsclifton bsclifton merged commit 3e657fb into 0.71.x Sep 6, 2019
@bsclifton bsclifton deleted the pr3357_fix-sync-error-ui_0.71.x branch September 6, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @bsclifton @brave-browser-releases