Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Uphold logo with their updated version. #5876

Closed
jenn-rhim opened this issue Sep 3, 2019 · 3 comments · Fixed by brave/brave-core#3447
Closed

Replace Uphold logo with their updated version. #5876

jenn-rhim opened this issue Sep 3, 2019 · 3 comments · Fixed by brave/brave-core#3447
Assignees
Labels
design A design change, especially one which needs input from the design team feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@jenn-rhim
Copy link

Description

Uphold refreshed their logo with the single color version. The rainbow ballon is an old one and needs to be replaced.

[old]
image

[new]

image

logo file:
img-uphold-logo

@NejcZdovc

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bsclifton bsclifton added design A design change, especially one which needs input from the design team feature/rewards labels Sep 3, 2019
@NejcZdovc NejcZdovc self-assigned this Sep 4, 2019
@NejcZdovc
Copy link
Contributor

@jenn-rhim I need svg

@NejcZdovc NejcZdovc assigned ryanml and unassigned NejcZdovc Sep 16, 2019
@NejcZdovc
Copy link
Contributor

svg version send by @jenn-rhim
uphold-logo-only.svg.zip

@btlechowski
Copy link

btlechowski commented Sep 28, 2019

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

brave://rewards page
image
image
Brave Rewards Panel
image
brave://rewards/#verify
image

Verified passed with

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified logo displayed correctly on Verify Wallet modal:

Screen Shot 2019-09-30 at 8 48 01 AM

* Verified logo displayed correctly on brave://rewards page for Verified user wallet:

Screen Shot 2019-09-30 at 9 04 45 AM

* Verified logo displayed correctly on panel for Verified user wallet:

Screen Shot 2019-09-30 at 9 05 05 AM

* Unable to check connected (not KYC'd) user wallet due to #6224

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified logo displayed correctly on Verify Wallet modal:

image

  • Verified logo displayed correctly on brave://rewards page for Verified user wallet:

image

  • Verified logo displayed correctly on panel for Verified user wallet:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants