Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change maximum ads on Android/iOS to 20 #6362

Closed
jsecretan opened this issue Oct 8, 2019 · 3 comments · Fixed by brave/brave-core#3635
Closed

Change maximum ads on Android/iOS to 20 #6362

jsecretan opened this issue Oct 8, 2019 · 3 comments · Fixed by brave/brave-core#3635
Assignees
@tmancey
Labels
ARM Android ARM related issues feature/ads OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.1.x - Release

Comments

@jsecretan
Copy link

Description

The maximum ads per day on Android/iOS should match desktop at 20. This will allow users who are requesting greater ads rewards to see them.
@jsecretan jsecretan added priority/P2 A bad problem. We might uplift this to the next planned release. feature/ads labels Oct 8, 2019
@tmancey tmancey mentioned this issue Oct 8, 2019
Merged
32 tasks
@SergeyZhukovsky SergeyZhukovsky added OS/Android Fixes related to Android browser functionality and removed android-related labels Oct 10, 2019
tmancey added a commit to brave/brave-core that referenced this issue Oct 15, 2019
@tmancey
Change maximum ads on Android/iOS to 20
3f542e1 
Fixes brave/brave-browser#6362
@tmancey tmancey added this to the 0.72.x - Nightly milestone Oct 15, 2019
@LaurenWags
Copy link
Member

Adding QA/Blocked label pending discussion about testing cc @kjozwiak

This was referenced Dec 2, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

Removing QA/Blocked label as we have received assistance from @tmancey on how to test this one.

@LaurenWags
Copy link
Member

LaurenWags commented Dec 6, 2019 •
edited
Loading

Verified passed with

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified using file provided to QA and test plan shared with QA. If you need the test plan DM me.

Verification passed on

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Windows 10 OS Version 1809 (Build 17763.864)

@LaurenWags LaurenWags mentioned this issue Dec 6, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Dec 9, 2019
Closed
88 tasks
@LaurenWags LaurenWags added the ARM Android ARM related issues label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
ARM Android ARM related issues feature/ads OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging a pull request may close this issue.

Change maximum ads on Android/iOS to 20 brave/brave-core
5 participants
@jsecretan @tmancey @SergeyZhukovsky @LaurenWags @btlechowski