Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ads panel description on brave://rewards is not translated #6868

Closed
btlechowski opened this issue Nov 11, 2019 · 4 comments
Closed

ads panel description on brave://rewards is not translated #6868

btlechowski opened this issue Nov 11, 2019 · 4 comments

Comments

@btlechowski
Copy link

btlechowski commented Nov 11, 2019

Important: not reproducible on 0.70.x nor on 0.74.x

Steps to Reproduce

  1. Open Brave in Polish locale
  2. Open brave://rewards

Actual result:

ads panel description is not translated
image

Expected result:

ads panel description is translated
image

Reproduces how often:

Always

Brave version (brave://version info)

Reproducible on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

Not Reproducible on 0.70.x, nightly

Brave 0.70.123 Chromium: 78.0.3904.97 (Oficjalna wersja) (64-bitowa)
Wersja 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24530)
Brave 0.74.7 Chromium: 78.0.3904.87 (Oficjalna wersja) nightly (64-bitowa)
Wersja 20c21f4010010f32462ea8e1d6af30cef66d48c8-refs/branch-heads/3904@{#840}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24530)

cc @brave/legacy_qa @rebron @mkarolin @ryanml

@btlechowski
Copy link
Author

@rebron @mkarolin This is a recent regression introduced between 0.70.111/0.70.112 and 0.70.113.

The issue started to reproduce on 0.70.113.

@LaurenWags
Copy link
Member

Reproduces with other languages (Russian) as well.

Brave 0.71.114 Chromium: 78.0.3904.97 (Официальная сборка) (64 бит)
Версия 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
ОС macOS Версия 10.13.6 (Выпуск 17G5019)

Screen Shot 2019-11-11 at 9 27 29 ДП

@mkarolin
Copy link
Contributor

Fixed via brave/brave-core#3979

@btlechowski
Copy link
Author

btlechowski commented Nov 12, 2019

Verification passed on

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

Verified STR from the description

tokens - Polish
image

tokens - English
image

points - English
image

points - Japanese
image

Verified passed with

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

Russian
Russian

Japanese (points)
Japanese

English (points)
English(points)

English (tokens)
English(tokens)

Verification passed on

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description
    Token- Polish
    image

Token - English (New Zealand)
image

Points- Japanese

image

Tokens - English (US)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment