Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave://version page shows Chromium logo/name on dark theme #7221

Closed
LaurenWags opened this issue Dec 5, 2019 · 2 comments · Fixed by brave/brave-core#4149
Closed

brave://version page shows Chromium logo/name on dark theme #7221

LaurenWags opened this issue Dec 5, 2019 · 2 comments · Fixed by brave/brave-core#4149
Assignees
@mkarolin
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.1.x - Release

Comments

@LaurenWags
Copy link
Member

Description

C79 builds show 'Chromium' name and logo on brave://version page, but only on dark theme.

Does not reproduce with C78 builds.

Steps to Reproduce

  1. Have theme set to light.
  2. Navigate to brave://version
  3. See Brave name/logo/info as expected.
  4. Change theme to dark.
  5. Navigate to brave://version

Actual result:

See Chromium name/logo
Screen Shot 2019-12-05 at 12 09 58 PM

Expected result:

For it to be the same as light theme:
Screen Shot 2019-12-05 at 12 10 11 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.1.18 Chromium: 79.0.3945.56 (Official Build) (64-bit)
Revision 73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, not with 1.0.1
  • Can you reproduce this issue with the beta channel? unsure
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @bsclifton @mkarolin @rebron @brave/legacy_qa

Does not reproduce for 1.0.1 with C78 (although 1.0.1 does not have the version background page as dark for High Sierra).
Dark:
Screen Shot 2019-12-05 at 12 12 00 PM

Light:
Screen Shot 2019-12-05 at 12 11 48 PM
@LaurenWags LaurenWags added about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages QA/Yes QA/Test-Plan-Specified regression labels Dec 5, 2019
@LaurenWags LaurenWags added this to the 1.1.x - Release milestone Dec 5, 2019
@LaurenWags LaurenWags mentioned this issue Dec 5, 2019
Closed
@mkarolin mkarolin self-assigned this Dec 5, 2019
@mkarolin mkarolin mentioned this issue Dec 5, 2019
Merged
32 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Dec 5, 2019
@mkarolin
Fixes brave://version Brave logo in dark mode.
fa96922 
Fixes brave/brave-browser#7221

Copied product_logo.png to product_logo_white.png to be used in dark
mode.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/7ccedcb1069f7a3ae1a17f835bdfa148bdad326a

commit 7ccedcb1069f7a3ae1a17f835bdfa148bdad326a
Author: Robbie Gibson <rkgibson@google.com>
Date:   Thu Oct 10 10:20:24 2019 +0000

    Add dark mode styling to chrome://version

    The uses the <picture> element to select different sources for the logo
    image based on the device's mode. It also moves the white logo files
    to the same place as the existing files for consistency. There are
    corresponding CLs to move the google_chrome logo files as well.

    Bug: 1006216
@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 -1.1.18

image

This was referenced Dec 6, 2019
Merged
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2019 •
edited by LaurenWags
Loading

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS macOS Version 10.15.1 (Build 19B88)

Ensured that the correct icon is being displayed under brave://version when going through the following:

  • switching between light & dark themes via chrome://settings/appearance
  • ensuring that Same as macOS is selected and using light as the OS theme
  • ensuring that Same as macOS is selected and using dark as the OS theme
  • ensured that restarting the browser while in dark mode still retains the correct image

Examples:

Screen Shot 2019-12-08 at 7 11 25 PM

Screen Shot 2019-12-08 at 7 12 33 PM

Verification passed on

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

image

Verified passed with

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Windows 10 OS Version 1809 (Build 17763.864)

Screen Shot 2019-12-09 at 5 23 41 PM

Screen Shot 2019-12-09 at 5 24 12 PM

This was referenced Dec 9, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes brave://version Brave logo in dark mode. brave/brave-core
6 participants
@kjozwiak @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin