Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields button always shows the counts of active tab of active windows #743

Closed
simonhong opened this issue Aug 13, 2018 · 1 comment
Closed

Shields button always shows the counts of active tab of active windows #743

simonhong opened this issue Aug 13, 2018 · 1 comment
Assignees
@petemill
Labels
feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@simonhong
Copy link
Member

Description

Shield text always shows the count of active tab of active window

Steps to Reproduce

  1. Create new window with new tab
  2. Create new window with www.github.com

Actual result:

All shield button shows the count of active window's

Expected result:

Shield button in each window should show the count of it's active tab

Reproduces how often:

Easily reproduced

Brave version (about:brave info)

Master

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added the feature/shields The overall Shields feature in Brave. label Aug 13, 2018
@bbondy bbondy added this to the Backlog milestone Aug 16, 2018
@petemill petemill self-assigned this Aug 27, 2018
petemill added a commit to petemill/brave-extension that referenced this issue Aug 27, 2018
@petemill
Set shields badge count for active tab only
eb9bb8a 
Fix brave/brave-browser#743
@petemill petemill mentioned this issue Aug 27, 2018
Merged
petemill added a commit to petemill/brave-extension that referenced this issue Aug 27, 2018
@petemill
Initialize the Browser Action and set some settings:
b2511ea 
- Badge color
- Higher resolution (vector) icon
  (Fix brave/brave-browser#844)
- Badge displays '99+' when block count is > 99
- Shields are disabled for non-http(s) sites
  (Fix brave/brave-browser#503)
- Default icon before a tab loads is the shields-on icon
- Set shields badge count for active tab only
  (Fix brave/brave-browser#743)

Address some features of brave/brave-browser#668
@bbondy bbondy modified the milestones: Backlog, Releasable builds 0.55.x Aug 30, 2018
@srirambv srirambv added the QA/Yes label Sep 9, 2018
@btlechowski
Copy link

btlechowski commented Sep 20, 2018 •
edited by srirambv
Loading

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verification Pass with

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @bbondy @simonhong @srirambv @LaurenWags @btlechowski