Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error/warning page communication and iconography & use Google Safe Browsing via proxy #7464

Open
karenkliu opened this issue Dec 19, 2019 · 3 comments
Open

Update error/warning page communication and iconography & use Google Safe Browsing via proxy #7464

karenkliu opened this issue Dec 19, 2019 · 3 comments
Assignees
@deeppandya @anthonypkeane
Labels
branding design A design change, especially one which needs input from the design team feature/safebrowsing OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@karenkliu
Copy link

karenkliu commented Dec 19, 2019 •
edited
Loading

Description

As on desktop, we should use Google's Safe Browsing service to avoid phishing & malware.

Designs

Create responsive webpage designs that work for mobile & desktop widths.

Interstitial pages:

image

Page might charge you money:

image

Connection not private:

image

Phishing warning:

image

Malware warning:

image

Unwanted software warning:

image

Assets

Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=0%3A49

Test Plan

  1. Navigate to https://testsafebrowsing.appspot.com
  2. Confirm all webpage warnings URLs display the safe browsing warning.

Notes

Given that these are webpages, the same design is used for all platforms. iOS: brave/brave-ios#483
@karenkliu
Copy link
Author

karenkliu commented Dec 19, 2019 •
edited
Loading

Cross-platform reference:
Desktop: #1149 (comment)
iOS: brave/brave-ios#483

@anthonypkeane anthonypkeane transferred this issue from another repository Dec 19, 2019
@rebron rebron added design A design change, especially one which needs input from the design team priority/P3 The next thing for us to work on. It'll ride the trains. branding labels Feb 14, 2020
@karenkliu
Copy link
Author

Updated designs to reflect that these should be full-screen HTML pages using our web UI.

@bsclifton bsclifton added the OS/Android Fixes related to Android browser functionality label Jul 27, 2020
@bsclifton
Copy link
Member

Added missing Android label so we don't miss this 😄

This was referenced Dec 2, 2020
Closed
Open
@LaurenWags LaurenWags mentioned this issue Mar 18, 2021
Closed
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

@anthonypkeane anthonypkeane

Labels
branding design A design change, especially one which needs input from the design team feature/safebrowsing OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
Front End
Status: P4 backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fmarier @karenkliu @bsclifton @deeppandya @rebron @anthonypkeane