Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning when changing between advanced vs simple shields view isn't visible when using dark more #7628

Closed
kjozwiak opened this issue Jan 7, 2020 · 2 comments · Fixed by brave/brave-core#4328
Closed

warning when changing between advanced vs simple shields view isn't visible when using dark more #7628

kjozwiak opened this issue Jan 7, 2020 · 2 comments · Fixed by brave/brave-core#4328
Assignees
@cezaraugusto
Labels
bug feature/shields The overall Shields feature in Brave. feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.5.x - Release

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Jan 7, 2020

Description

The warning when switching between Simple vs Advanced mode under Shields isn't visible when using dark mode as per the example below.

Steps to Reproduce

  1. install & launch 1.5.13 CR: 79.0.3945.88
  2. visit https://brave.com and click on the Brave Shield
  3. select Advanced View

Actual result:

Screen Shot 2020-01-07 at 2 20 28 AM

Expected result:

Screen Shot 2020-01-07 at 2 19 30 AM

Reproduces how often:

100% reproducible when using the above STR.

Brave version (brave://version info)

Brave 1.5.13 Chromium: 79.0.3945.88 (Official Build) nightly (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.15.2 (Build 19C57)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not reproducible using 1.2.41 CR: 79.0.3945.88
  • Can you reproduce this issue with the beta channel? Reproducible using 1.3.85 CR: 79.0.3945.88
  • Can you reproduce this issue with the dev channel? Reproducible using 1.4.52 Chromium: 79.0.3945.88
  • Can you reproduce this issue with the nightly channel? Reproducible using 1.5.13 CR: 79.0.3945.88

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa @bsclifton @rebron
@bsclifton
Copy link
Member

@cezaraugusto is this because of a Brave UI change?

cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 8, 2020
@cezaraugusto
Improve warning text contrast on Shields dark mode
6cec5ba 
Fix brave/brave-browser#7628

When opening Shields advanced panel in dark mode for the
first time, users see a warning text with low contrast
making reading difficult.
@cezaraugusto cezaraugusto mentioned this issue Jan 8, 2020
Merged
6 tasks
bsclifton pushed a commit to brave/brave-core that referenced this issue Jan 9, 2020
@cezaraugusto @bsclifton
Improve warning text contrast on Shields dark mode
9a75636 
Fix brave/brave-browser#7628

When opening Shields advanced panel in dark mode for the
first time, users see a warning text with low contrast
making reading difficult.
@bsclifton bsclifton added this to the 1.5.x - Nightly milestone Jan 10, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Feb 26, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 1.5.101 Chromium: 80.0.3987.116 (Official Build) beta (64-bit)
Revision dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-02-26 at 5 01 39 PM

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Ubuntu 18.04 LTS

image
image

Verification passed on

Brave 1.5.108 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@kjozwiak kjozwiak mentioned this issue Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/shields The overall Shields feature in Brave. feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging a pull request may close this issue.

Improve warning text contrast on Shields dark mode brave/brave-core
6 participants
@kjozwiak @cezaraugusto @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya