Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle distilled page contents is really long in Bulgarian #8083

Closed
btlechowski opened this issue Feb 5, 2020 · 6 comments
Closed

Toggle distilled page contents is really long in Bulgarian #8083

btlechowski opened this issue Feb 5, 2020 · 6 comments
Assignees
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@btlechowski
Copy link

Looks like translation of Toggle distilled page contents is really long in Bulgarian. It uses 6 distinct words. Google translate uses 4.

Steps to Reproduce

  1. Open Brave in Bulgarian
  2. Open Hamburger Menu

Actual result:

Toggle distilled page contents is really long compared to google translate
Hamburger menu is really stretched
image

Expected result:

Closer to google translate
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision 583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS Ubuntu 18.04 LTS
Brave 1.5.69 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Ubuntu 18.04 LTS

cc @mkarolin @rebron @bsclifton

@mkarolin
Copy link
Contributor

mkarolin commented Feb 6, 2020

The translation comes from Chromium. We can change, of course.

image

@rebron
Copy link
Collaborator

rebron commented Feb 6, 2020

We should go shorter with this string and just translate "Distill page" like on macOS. That looks bad.

@bsclifton
Copy link
Member

bsclifton commented Mar 11, 2020

I believe we're going to replace this with Speedreader. @rebron did you want to create an overall issue for enabling speedreader + disabling page distill? Maybe we can close issues like this on our next triage session

@rebron rebron self-assigned this Mar 27, 2020
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels Apr 3, 2020
@rebron
Copy link
Collaborator

rebron commented Apr 20, 2020

@btlechowski Can you take a look at this again for 1.8.x later this week? Toggle distilled page contents is now Toggle reader mode in Windows and just Reader mode on macOS starting with chromium 81.

@btlechowski
Copy link
Author

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Ubuntu 18.04 LTS

Verified test plan from the description. The string is much shorter.

image

@LaurenWags
Copy link
Member

LaurenWags commented Apr 21, 2020

Verified passed with

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

English:
Screen Shot 2020-04-21 at 1 41 49 PM

Bulgarian:
Screen Shot 2020-04-21 at 1 43 10 PM

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1803 (Build 17134.1006)

English
image

Bulgarian

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix l10n priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

6 participants