Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NamedThirdPartyRegistry initialization of blocking execution path #8186

Closed
AndriusA opened this issue Feb 11, 2020 · 1 comment · Fixed by brave/brave-core#5437
Closed

Comments

@AndriusA
Copy link

Description

brave/brave-core#4229 implements bandwidth savings prediction using named third parties as one of the signals for the predictive model. Third parties are looked up by domain name in NamedThirdPartyRegistry, but NamedThirdPartyRegistry is a singleton that loads mappings from JSON on first use, potentially locking up the main thread.

Steps to Reproduce

N/A

Actual result:

Histogram Brave.Savings.NamedThirdPartyRegistry.LoadTimeMS records tame taken for initialization - simple experiment on a powerful desktop shows 4ms spent.

Expected result:

Loading the bandwidth prediction component should not block request processing

Reproduces how often:

Every browser launch

Brave version (brave://version info)

Current devevlopment, not yet landed

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the dev channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@bsclifton
Copy link
Member

Setting missing milestone to 1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants