Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandwidth savings feature #4229

Merged
merged 9 commits into from
Feb 12, 2020
Merged

Bandwidth savings feature #4229

merged 9 commits into from
Feb 12, 2020

Conversation

AndriusA
Copy link

@AndriusA AndriusA commented Dec 13, 2019

Closes brave/brave-browser#7783

Submitter Checklist:

Test Plan:

Feature implemented for the "Data Saved vs HTTPS in Stats" draft spec and based on earlier research per https://brave.com/accurately-predicting-ad-blocker-savings/

Testing would involve browsing a range of different pages with shields up/down and observing total transfer sizes in developer tools. The number isn't expected to match the observations precisely on every individual page, but rather over a longer browsing session of 10-30 or more pages visited.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@AndriusA AndriusA self-assigned this Dec 13, 2019
DEPS Outdated Show resolved Hide resolved
browser/BUILD.gn Outdated Show resolved Hide resolved
@AndriusA
Copy link
Author

Now rebased on master and including P3A for the metric

@AndriusA AndriusA force-pushed the feature-bandwidth-savings branch 4 times, most recently from 80c4318 to 3aefe80 Compare January 13, 2020 17:43
common/pref_names.cc Outdated Show resolved Hide resolved
@iefremov iefremov self-requested a review February 11, 2020 17:49
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! pls file an issue for offloading of NamedThirdPartyRegistry initialization

@AndriusA
Copy link
Author

Tracking the follow-up to move NamedThirdPartyRegistry in brave/brave-browser#8186

@AndriusA AndriusA merged commit df93c16 into master Feb 12, 2020
@AndriusA AndriusA deleted the feature-bandwidth-savings branch February 12, 2020 06:34
@bbondy bbondy added this to the 1.7.x - Release milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estimated bandwidth savings in NTP
6 participants