-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bandwidth savings feature #4229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Dec 19, 2019
patches/chrome-browser-page_load_metrics-page_load_metrics_initialize.cc.patch
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Dec 19, 2019
patches/chrome-browser-page_load_metrics-page_load_metrics_initialize.cc.patch
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Dec 19, 2019
bridiver
reviewed
Dec 19, 2019
components/brave_savings/browser/perf_predictor_page_metrics_observer.cc
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Dec 19, 2019
bridiver
reviewed
Dec 19, 2019
bridiver
reviewed
Dec 19, 2019
components/brave_savings/browser/perf_predictor_web_contents_observer.cc
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Dec 19, 2019
components/brave_savings/browser/perf_predictor_page_metrics_observer.cc
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Dec 19, 2019
bridiver
reviewed
Dec 19, 2019
bridiver
reviewed
Dec 19, 2019
components/brave_savings/browser/perf_predictor_web_contents_observer.cc
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Dec 19, 2019
components/brave_savings/browser/perf_predictor_web_contents_observer.cc
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Jan 9, 2020
components/brave_perf_predictor/browser/third_party_extractor.cc
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Jan 9, 2020
components/brave_perf_predictor/browser/perf_predictor_tab_helper.h
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Jan 9, 2020
components/brave_perf_predictor/browser/perf_predictor_tab_helper.h
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Jan 9, 2020
AndriusA
force-pushed
the
feature-bandwidth-savings
branch
from
January 10, 2020 17:24
c95546e
to
7a5c7e8
Compare
Now rebased on master and including P3A for the metric |
AndriusA
force-pushed
the
feature-bandwidth-savings
branch
4 times, most recently
from
January 13, 2020 17:43
80c4318
to
3aefe80
Compare
bridiver
reviewed
Jan 13, 2020
chromium_src/components/page_load_metrics/page_load_metrics_embedder_base.cc
Outdated
Show resolved
Hide resolved
AndriusA
force-pushed
the
feature-bandwidth-savings
branch
from
January 13, 2020 21:58
57387b7
to
5a4f7f8
Compare
bridiver
reviewed
Jan 14, 2020
bridiver
reviewed
Jan 15, 2020
bridiver
reviewed
Jan 15, 2020
bridiver
reviewed
Jan 15, 2020
components/brave_perf_predictor/browser/p3a_bandwidth_savings_tracker.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Feb 11, 2020
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/bandwidth_linreg_parameters.h
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Feb 11, 2020
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/bandwidth_savings_predictor_unittest.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/bandwidth_savings_predictor_unittest.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Feb 11, 2020
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/p3a_bandwidth_savings_permanent_state.h
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/p3a_bandwidth_savings_permanent_state.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/p3a_bandwidth_savings_tracker.cc
Outdated
Show resolved
Hide resolved
bridiver
reviewed
Feb 11, 2020
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/perf_predictor_tab_helper.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
Feb 11, 2020
components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc
Outdated
Show resolved
Hide resolved
iefremov
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! pls file an issue for offloading of NamedThirdPartyRegistry initialization
Tracking the follow-up to move |
…nd extra debugging in the component
…del to reduce memory footprint
…ontents have gone away
AndriusA
force-pushed
the
feature-bandwidth-savings
branch
from
February 11, 2020 21:46
5455e0f
to
1b0dbc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes brave/brave-browser#7783
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Feature implemented for the "Data Saved vs HTTPS in Stats" draft spec and based on earlier research per https://brave.com/accurately-predicting-ad-blocker-savings/
Testing would involve browsing a range of different pages with shields up/down and observing total transfer sizes in developer tools. The number isn't expected to match the observations precisely on every individual page, but rather over a longer browsing session of 10-30 or more pages visited.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.