Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic filtering causes a layout re-flow during page-load #8197

Closed
petemill opened this issue Feb 11, 2020 · 1 comment · Fixed by brave/brave-core#4585
Closed

Cosmetic filtering causes a layout re-flow during page-load #8197

petemill opened this issue Feb 11, 2020 · 1 comment · Fixed by brave/brave-core#4585

Comments

@petemill
Copy link
Member

Cosmetic filtering was enabled (behind a flag) with brave/brave-core#4269

When enabled, it detects which potentially-hidden elements contain 1st party content vs 3rd party content. After the determination, 3rd party content is hidden and 1st party content is left alone. This causes a jump of content when elements are hidden some time after the are first displayed.

Test Plan

  1. Enable chrome://flags/#brave-adblock-cosmetic-filtering
  2. Visit latimes.com
  3. Visit some articles

Actual

Content jumps
cosmetic-jump-brave

Expected

Content is already hidden
cosmetic-jump-chrome

@srirambv
Copy link
Contributor

srirambv commented Apr 6, 2020

Verification passed on

Brave 1.7.85 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified using

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants