Avoid layout re-flow for cosmetic filtering #4585
Conversation
petemill
force-pushed
the
insta-cosmetic-filtering
branch
from
1a65948
to
d7b7094
Compare
petemill
force-pushed
the
insta-cosmetic-filtering
branch
from
d7b7094
to
9c24069
Compare
| .map(selector => | ||
| allSelectorsToRules.get(selector) | ||
| ) | ||
| .filter(i => i !== undefined) |
There was a problem hiding this comment.
what is this checking? I dont see why this could happen
There was a problem hiding this comment.
if allSelectorsToRules is passed a selector it does not contain then it will give us an undefined entry, which is going to mess with knowing the count to shift other indexes, as well as we'll have to check for it anyway before attempting to remove the undefined index rule.
We may know this cannot happen, but this function does not, and if we pass undefined to CSSStyleSheet.deleteRule() then it's not going to delete the rule we intended and all our indexes will be off.
| } | ||
| continue | ||
| } | ||
| if (oldIdx !== i) { |
There was a problem hiding this comment.
similarly, whats going on here?
There was a problem hiding this comment.
A sanity check that any previous re-indexes have kept this item in-sync. Though since we expect the actual index of an item in the Map to match the lookup value of the Map's item, we probably may as well use a combination of Set and array. Either way we would be doing something like converting Set to Array to find an index, or using indexOf for the lookup. So, this works for now and seems just as performant. Having said that, would love to optimize if you can think of a way.
petemill
force-pushed
the
insta-cosmetic-filtering
branch
from
9c24069
to
5ec0bd5
Compare
petemill
added
CI/skip-android
|
Just re-building macOS. Sure it's fine, but being double-safe |
…they are found to be 1st-party Fixes layout re-flow Co-authored-by: Pete Miller <miller.pete@gmail.com>
Since we do not have a chrome.tabs.removeCSS API, we need another method for restoring the page's original css `display` rule value. Adding and removing rule via a constructed CSSStyleSheet injected via document.adoptedStyleSheets serves this purpose.
petemill
force-pushed
the
insta-cosmetic-filtering
branch
from
5ec0bd5
to
36c8577
Compare
petemill
removed
CI/skip-android
|
Updated to add missing milestone (both to this PR and the issue 👍) |
Resolves brave/brave-browser#8197
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.