Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop :: Implement Custom Homepage #8218

Closed
6 tasks done
anthonypkeane opened this issue Feb 12, 2020 · 2 comments · Fixed by brave/brave-core#4866
Closed
6 tasks done

Desktop :: Implement Custom Homepage #8218

anthonypkeane opened this issue Feb 12, 2020 · 2 comments · Fixed by brave/brave-core#4866

Comments

@anthonypkeane
Copy link

anthonypkeane commented Feb 12, 2020

@rebron
Copy link
Collaborator

rebron commented Apr 27, 2020

@anthonypkeane @LaurenWags
Suggested for release notes: Added support for referral background images and top sites on the new tab page

@LaurenWags
Copy link
Member

LaurenWags commented Apr 28, 2020

Verified passed with

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS macOS Version 10.14.6 (Build 18G3020)

SR Install - see issues logged/noted below

  • Confirmed able to get Technikke images and top site tiles on each NTP opened
  • Confirmed SR component on brave://components
  • Confirmed promoCode in brave://local-state
  • Confirmed there is a new theme page at brave://settings/themes
  • Could not disable SR images on brave://settings/themes (See logged issue below)

Screen Shot 2020-04-28 at 4 49 21 PM

Screen Shot 2020-04-28 at 4 49 43 PM

Non-SR Install - PASSED

  • Confirmed new install without SR does not have brave://settings/themes page
  • Confirmed only standard NTP SI component is available, no SR component

Other scenarios:

  1. User has default code/non SR code - PASSED
  • Confirmed only standard NTP SI component is available, no SR component
  1. User has empty code (profile is over 90 days) - PASSED
  • Confirmed only standard NTP SI component is available, no SR component

Logged issues

Verification passed on

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Super Referral code install:

image
image
image
image

Non-Super Referral Install - PASSED

Confirmed new install without SR does not have brave://settings/themes page
Confirmed only standard NTP SI component is available, no SR component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment