Generate NTP Super Referrer(SR) component #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
super-referrer-package
branch
2 times, most recently
from
ddbf29e
to
7031ab4
Compare
6 tasks
|
This PR works well with https://ci.brave.com/view/all-extensions/job/brave-core-ext-ntp-super-referrer-component-dev/ |
simonhong
force-pushed
the
super-referrer-package
branch
from
7031ab4
to
7b21dea
Compare
simonhong
force-pushed
the
super-referrer-package
branch
from
7b21dea
to
c097f65
Compare
simonhong
changed the title
bsclifton
reviewed
Mar 17, 2020
| console.log(`Downloading for ${referrerName}...`) | ||
| const targetResourceDir = path.join(rootResourceDir, referrerName) | ||
| mkdirp.sync(targetResourceDir) | ||
| const jsonFileUrl = `${dataUrl}superreferrer/${referrerName}/${jsonFileName}` |
There was a problem hiding this comment.
beautiful- so this just uses the iOS URL to get the resources? 😎👍
There was a problem hiding this comment.
In Jenkins job, our s3 bucket full url is passed. but not sure iOS dev will use same url or alias url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: brave/brave-browser#8218