Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Users should be able to import payment methods #8329

Closed
rebron opened this issue Feb 20, 2020 · 5 comments · Fixed by brave/brave-core#5582
Closed

[Desktop] Users should be able to import payment methods #8329

rebron opened this issue Feb 20, 2020 · 5 comments · Fixed by brave/brave-core#5582

Comments

@rebron
Copy link
Collaborator

rebron commented Feb 20, 2020

Description

Users should be able to import Payment methods (aka credit card data) from Chrome in order to ease switching from Chrome to Brave.

Expected Results

  1. Go to Import Bookmarks and Settings.
  2. When selecting a Chrome "Person", user should be presented with a check box default checked for "Payment methods" if payment method data is available. No check box should be present if no payment method information is available.
  3. Upon selecting Payment method checkbox and selecting Import, user should see Payment method information imported into brave://settings/payments and can now be used for payment method form autofill.

Payment method information should also default import if data is available during brave://welcome onboarding.

Miscellaneous Information:

Currently available in MS Edge.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Feb 25, 2020
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels May 12, 2020
@simonhong simonhong added this to the 1.11.x - Nightly milestone May 15, 2020
@rebron rebron changed the title Users should be able to import payment methods [Desktop] Users should be able to import payment methods Jul 20, 2020
@rebron
Copy link
Collaborator Author

rebron commented Aug 7, 2020

Verified on Windows.

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Windows 10 OS Version 2004 (Build 19041.388)

Followed test plan in the PR and ensured 1) no checkbox is shown if no payment methods are available to import from Chrome and 2) ensured that payment method checkbox is shown if available and I successfully imported payment method. Note that if a payment method is part of Google Pay, those payment methods are not imported due to having to be logged in to Google Pay.

Also ensured that payment methods are imported successfully during the onboarding process.

Used:

Google Chrome 84.0.4147.105 (Official Build) (64-bit) (cohort: Stable)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Windows 10 OS Version 2004 (Build 19041.388)

@LaurenWags
Copy link
Member

LaurenWags commented Aug 7, 2020

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#5582

Confirmed no Payment methods checkbox if no payment methods exist in Chrome:

Screen Shot 2020-08-07 at 1 24 52 PM

Confirmed all items above imported successfully from brave://settings/importData and brave://welcome

Confirmed if at least one payment method is saved in Chrome then the Payment methods checkbox is shown:

Screen Shot 2020-08-07 at 1 34 28 PM

Confirmed all items above imported successfully from brave://settings/importData and brave://welcome

Imported from below version of Chrome

Google Chrome | 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on


Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

  • Verified test plan from Import payments info from chrome brave-core#5582

  • Confirmed no Payment methods checkbox if no payment methods exist in Chrome:
    image

  • Confirmed if at least one payment method is saved in Chrome then the Payment methods checkbox is shown:
    image

  • Confirmed Payment Method details are shown correctly after import
    image

  • Confirmed all items above imported successfully from brave://settings/importData and brave://welcome

Imported from below version of Chrome


Google Chrome | 84.0.4147.105 (Official Build) (64-bit) (cohort: Stable)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)



Verification passed on

Brave 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Confirmed if at least one payment method is saved in Chrome then the Payment methods checkbox is shown:
image

Confirmed all items above imported successfully from brave://settings/importData and brave://welcome
image

@sry9681
Copy link

sry9681 commented Aug 16, 2021

Whatever happened to this feature? I would love to import my payment methods and addresses from chrome to brave

@bsclifton
Copy link
Member

@sry9681 this should be showing... if you have payment methods populated. I just did a test and it's showing up for me
image

The important thing is that you need to pick the correct profile (from the drop down). There will be multiple Chrome profiles by default (especially if you have other versions installed, like Chrome Canary). Can you check that @sry9681?

@Dyltom
Copy link

Dyltom commented Nov 19, 2023

Is this feature still working? I only have one profile and there's no option to import payment methods from Chrome.

Screenshot 2023-11-19 at 11 20 55 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants