Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chrome-browser-importer-profile_writer.h.patch #14817

Closed
mariospr opened this issue Mar 18, 2021 · 1 comment · Fixed by brave/brave-core#8292
Closed

Remove chrome-browser-importer-profile_writer.h.patch #14817

mariospr opened this issue Mar 18, 2021 · 1 comment · Fixed by brave/brave-core#8292

Comments

@mariospr
Copy link
Contributor

mariospr commented Mar 18, 2021

Description

This patch could be removed in favour of a chromium_src override that would add the new AddCreditCard() method into place using the already existing AddAutofillFormDataEntries() method as leverage.

Brave version (brave://version info)

Brave 1.24.2 (Chromium 89.0.4389.90)

Miscellaneous Information:

This removal references a patch initially introduced with #8329 so please use either the "Expected results" section of the issue's description or the test plan detailed in brave/brave-core#5582 for QA purposes (i.e. check that things continue to work).

@mariospr mariospr added this to the 1.24.x - Nightly milestone Mar 18, 2021
@mariospr mariospr self-assigned this Mar 18, 2021
mariospr added a commit to brave/brave-core that referenced this issue Mar 18, 2021
This patch could be removed in favour of a chromium_src override that
would add the new AddCreditCard() method into place using the already
existing AddAutofillFormDataEntries() method as leverage.

Resolves brave/brave-browser#14817
@stephendonner
Copy link

stephendonner commented Mar 22, 2021

Verified PASSED using the testplan from brave/brave-core#8292 with nightly build

Brave 1.24.12 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS macOS Version 11.2.3 (Build 20D91)

Test 1

  • Launched Chrome and verified there was no payment method specified in Chrome -> Import Bookmarks and Settings...
  • Launched Brave -> Import Bookmarks and Settings... and verified payment methods option is hidden
Chrome, showing empty Payments Brave, Import dialog showing no Payment option
Screen Shot 2021-03-22 at 3 43 49 PM Screen Shot 2021-03-22 at 3 36 02 PM

Test 2

  • Launched Chrome and added an Amazon VISA credit-card payment method
  • Launched Brave and loaded the Import dialog and verified payment methods option was visible and checked by default
  • Started import via Brave -> Import Bookmarks and Settings... and checked Chrome's payment method was imported
VISA card in Chrome's Payments Import options showing Payment macOS Keychain dialog Importing into Brave Successful import in Payments
Screen Shot 2021-03-22 at 3 37 23 PM Screen Shot 2021-03-22 at 3 37 42 PM Screen Shot 2021-03-22 at 3 37 48 PM Screen Shot 2021-03-22 at 3 37 53 PM Screen Shot 2021-03-22 at 3 38 33 PM

Verification passed on

Brave 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5582
no payments method

image image

payments method

image image image

Verification passed on

Brave | 1.24.69 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified test plan from brave/brave-core#5582
no payments method

image image

payments method

image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment