brave://wallet alias not shown while looking up an ENS domain or on a suspicious site

[ryanml]

Reproduction steps:

1. Enable Crypto Wallets via brave://wallet
2. Visit a site that will trigger phishing detection, a list can be found here: https://github.com/MetaMask/eth-phishing-detect/blob/master/src/hosts.txt
3. Visit an ENS url, such as http://vitalik.eth

Results:

Expected: brave://wallet to be shown in the URL bar

[btlechowski]

@ryanml For http://vitalik.eth I get:

Is this expected behavior?

[ryanml]

@btlechowski yep that's the correct behavior for the final resolution. This fix just made sure that brave://wallet was showing when this was being redirected to. Thanks for checking.

[kjozwiak]

Quick notes for QA:

• You'll need to wait till ~/Library/Application\ Support/BraveSoftware/Brave-Browser-Dev/Safe\ Browsing pulls the lists before attempting the STR via brave://wallet alias not shown while looking up an ENS domain or on a suspicious site #8524 (comment)
• You can use http://sether.ws/ from https://github.com/MetaMask/eth-phishing-detect/blob/master/src/hosts.txt (most hosts/websites don't exist anymore).

[kjozwiak]

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

• launched 1.7.71 CR: 80.0.3987.149 and waited for the Safe Browsing list to download
• visit brave://wallet
• visited http://sether.ws and ensured Safe Browsing was triggered (Deceptive website)
• visited http://vitalik.eth and ensured brave://wallet appeared in the URL before https://app.ens.domains/name/vitalik.eth loaded

Verification passed on

Brave	1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Ubuntu 18.04 LTS

Verified test plan from the description

Verification passed on

Brave	1.7.73 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from the description