Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No conversion due to lack of Slash at the end of urlPattern #8648

Closed
btlechowski opened this issue Mar 11, 2020 · 5 comments
Closed

No conversion due to lack of Slash at the end of urlPattern #8648

btlechowski opened this issue Mar 11, 2020 · 5 comments
Assignees
Labels

Comments

@btlechowski
Copy link

Found while testing #8362

Steps to Reproduce

  1. In the catalog set urlPattern to https://travala.com
  2. In the catalog set targetUrl to https://travala.com
  3. trigger the ad
  4. click on the ad to open the targetUrl

Note: if you add / at the end the conversion is successful

Actual result:

No conversion due to lack of slash at the end of urlPattern.

Expected result:

TBD

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
Brave 1.7.54 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @tmancey @jsecretan @rebron

@tmancey
Copy link
Contributor

tmancey commented Apr 21, 2020

@btlechowski when visiting https://travala.com a slash is added at the end of the domain, this will only occur for URLs without a path. @jsecretan It is recommended that we enforce a / at the end of domains which do not have a path (I would expect this is very unlikely for conversion URLs) in the management console

@bsclifton
Copy link
Member

@tmancey is this issue closed? (asking as I see it's in Done column)

@tmancey tmancey closed this as completed Jun 3, 2020
@btlechowski
Copy link
Author

@tmancey Has this issue been fixed in the management console?

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
@tmancey
Copy link
Contributor

tmancey commented Jun 4, 2020

@btlechowski It has not been fixed server-side. Can you please raise a server-side ticket. Thanks

@btlechowski
Copy link
Author

Logged the issue in the repo that was suggested by @jsecretan : https://github.com/brave/ads-serve/issues/990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants