Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ad conversion detection fails if the target URL of the last shown ad matches the conversion URL pattern #4717

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 22, 2020

Resolves brave/brave-browser#8362

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@@ -694,6 +694,8 @@ void AdsImpl::OnPageLoaded(
return;
}

CheckAdConversion(url);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CheckAdConversion should be called for every call to OnPageLoaded otherwise ad conversion detection failed if the target URL of the last shown ad matches the conversion URL pattern

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 6a4e7ad into master Feb 22, 2020
@tmancey tmancey deleted the issues/8362 branch February 22, 2020 10:29
@btlechowski
Copy link

LGTM

brave/brave-browser#8362 (comment)

Logged brave/brave-browser#8648 for a special case

petemill pushed a commit that referenced this pull request Jul 27, 2020
Fix check for target os equality with 'ios'
petemill pushed a commit that referenced this pull request Jul 28, 2020
Fix check for target os equality with 'ios'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ad conversion detection fails if the target URL of the last shown ad matches the conversion URL pattern
3 participants