Dashboard clock should be toggled between 12- and 24-hour time (Enhancement)

[theHedster]

Test plan

See brave/brave-core#6667

Description

The Dashboard on a new tab displays 12-hour time and cannot be changed to 24-hour time.

Steps to Reproduce

1. Launch Brave.
2. Open a new tab. The Dashboard displays the current time in AM/PM 12-hour format.

Actual result:

Expected result:

Time display should allow toggling between 12- and 24-hour time.

Reproduces how often:

Occurs by design.

Brave version (brave://version info)

Brave 1.5.123 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Windows 10 OS Version 1903 (Build 18362.720)
JavaScript V8 8.0.426.30
Flash (Disabled)
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36
Command Line "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=PasswordImport,WebUIDarkMode,SimplifyHttpsIndicator --disable-features=AllowPopupsDuringPageUnload,AutofillServerCommunication,AudioServiceOutOfProcess,SmsReceiver,LookalikeUrlNavigationSuggestionsUI,WebXR,NotificationTriggers,VideoPlaybackQuality,WebXrGamepadModule --flag-switches-begin --flag-switches-end --enable-audio-service-sandbox --disable-webrtc-apm-in-audio-service --disable-sync
Executable Path C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path C:\Users\hedley.MONICA-PC\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations 5e3a236d-4113a79e

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? No
• Does the issue resolve itself when disabling Brave Rewards? No
• Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

This issue has been previously raised in #1308 where the request was for the Dash clock to respect the locale setting. However, most OSs allow the user to override the locale setting to force either 12- or 24-hour time. Therefore, the Dash clock should honour system time format, not locale format.

[DanielVenturini]

I'm using the Brave version 1.5.123 Chromium: 80.0.3987.163 (Official Build) (64-bit) in Lubuntu 16.04 and it'd very nice to have an option to change between 12-24 hour time. Like in #1308 (comment), I changed to pt-BR (Brazilian Portuguese) and relaunch, but it didn't work.

[bsclifton]

Related #7951

[eugeneseppel]

I also would vote for this issue. I live in Estonia and when I saw clock value "2:19" during daytime it was astonishing -- my first idea was that something is wrong with computer clock, battery and time synchronization. Of course in spoken language we say "two o'clock and nineteen minutes", but almost never write in this way. The same story for all post-soviet countries, like Russia and Ukraine.
Winter nights (as well as days) in the northern Europe are dark and full of terrors, so if you wake up and see "4 o'clock" there is no chance to distinguish whether it is a day or night. Same story during white nights in June:)

[A2-NieR]

Yes, please!

[sethasaurus]

PLEASE!

[wavesurf432]

It would be great to have the choice between 24 hour and am/pm!

On Windows 7 I noticed Brave would recognise system time, but not with Linux.

[sethasaurus]

OK I don't care anymore. Just removed the clock from my start page :)

[eugeneseppel]

On my MacOS Brave also shows the system time like "18:02", meanwhile on GNU/Linux it is a weird "6:02"

[bsclifton]

Great news everybody - I set aside some time earlier this week and got this sorted out 😄
🎉 brave/brave-core#6667 🎉

[btlechowski]

Verification passed on

Brave	1.16.54 Chromium: 86.0.4240.72 (Official Build) dev (64-bit)
Revision	581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6667

Verified in 12h format

Verified in 24h format

Verified Automatic (en_US) format

Verified Automatic (pl) format

Logged #12029 for missing translations.

Verified cycling formats by clicking the clock works

---

Verified passed with

Brave	1.16.57 Chromium: 86.0.4240.75 (Official Build) dev (x86_64)
Revision	c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6667

Confirmed new dropdown for clock time which defaults to locale's default (used US). Note, #7951 is not automatically solved by this issue (locale's default of 12 or 24 h is used, not the chosen option in settings)

Confirmed each setting on the Customize Dashboard popup is reflected on NTP when selected:

Confirmed able to click on the clock and cycle between the 3 options (Automatic, 12h, 24h).

Confirmed changing from the default setting of "Automatic (locale)" was retained on newly opened tabs and on browser restart.

Logged follow up issues:

• Drop down doesn't respect dark theme, uses light theme - [Desktop] optimize Clock drop down on Customize Dashboard settings for dark theme  #12060
• Using dark theme, the clock options are hard to read until you expand the drop down - Make clock options display better with dark theme #12061
• Clock options should be available on brave://settings/newTab for consistency - [Desktop] update brave://settings/newTab to include clock options #12062

---

Verification passed on

Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Verified test plan from brave/brave-core#6667

12 - hour format

24 - hour format

Verified Automatic (en_US) format

Confirmed each setting on the Customize Dashboard popup is reflected on NTP when selected:

Confirmed able to click on the clock and cycle between the 3 options (Automatic, 12h, 24h).

Confirmed changing from the default setting of "Automatic (locale)" was retained on newly opened tabs and on browser restart.

Encountered #12062, #7951 and #12060

[howdev]

wonder why this is a problem. before 116.68, it has been displaying 24hour clock