Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UN M49 area codes (which do not contain embargoed countries) in Brave Ads #9134

Closed
tmancey opened this issue Apr 10, 2020 · 3 comments · Fixed by brave/brave-core#5217
Closed

Support UN M49 area codes (which do not contain embargoed countries) in Brave Ads #9134

tmancey opened this issue Apr 10, 2020 · 3 comments · Fixed by brave/brave-core#5217
Assignees
@tmancey
Labels
enhancement feature/ads OS/macOS OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.9.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Apr 10, 2020 •
edited
Loading

Support UN M49 area codes (which do not contain embargoed countries) in Brave Ads (see https://unstats.un.org/unsd/methodology/m49/) as area codes are used for certain OS regional settings such as Spanish (Latin America) for Brazil
@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. feature/ads labels Apr 10, 2020
@tmancey tmancey self-assigned this Apr 10, 2020
@tmancey tmancey changed the title Support UN M49 area codes in Brave Ads Support non embargoed UN M49 area codes in Brave Ads Apr 10, 2020
@tmancey tmancey changed the title Support non embargoed UN M49 area codes in Brave Ads Support UN M49 area codes (which do not contain embargoed countries) in Brave Ads Apr 10, 2020
@tmancey tmancey mentioned this issue Apr 10, 2020
Merged
32 tasks
@tmancey tmancey added this to the 1.9.x - Nightly milestone Apr 11, 2020
@LaurenWags LaurenWags mentioned this issue May 18, 2020
Closed
@LaurenWags
Copy link
Member

@tmancey is going to grab some examples that will work for QA and then we will test this one out.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 19, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave | 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave | 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Versão 10.14.6 (Compilação 18G3020)

@btlechowski
Copy link

On Ubuntu 18.04 LTS area codes are not supported. Setting the issue as OS/Windows and OS/macOS. Regression test for regions will be done under #7817

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/macOS OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.9.x - Release
Development

Successfully merging a pull request may close this issue.

Support UN M49 area codes (which do not contain embargoed countries) in Brave Ads brave/brave-core
4 participants
@tmancey @LaurenWags @btlechowski @GeetaSarvadnya