Additional phase of Brave Ads regions #7817

tmancey · 2020-01-19T14:08:28Z

Add the following regions to Brave Ads:

jwchong · 2020-03-10T09:41:21Z

Pls add Malaysia into the region list.

eljuno · 2020-03-10T10:19:34Z

@jwchong Malaysia is already supported (#6825) -- https://brave.com/transparency/

jsecretan · 2020-03-24T12:53:56Z

For privacy reasons, we should put the follow country codes together under a country code for Other "??":

AS
AI
AQ
AG
BQ
BV
IO
CF
TD
CX
CC
KM
CK
GQ
ER
FK
TF
GL
GW
HM
VA
KI
LR
MH
YT
FM
MS
NR
NU
NF
MP
PW
PN
BL
SH
KN
MF
PM
WS
SM
ST
SX
SB
GS
SS
SJ
TJ
TL
TK
TM
TC
TV
UM
VU
VG
WF
EH

GeetaSarvadnya · 2020-05-05T14:34:20Z

@jsecretan @tmancey Cannot verify the issue as catalog is empty for additional ad regions, for more details please refer https://bravesoftware.slack.com/archives/CJL3G0S95/p1588687877157000

LaurenWags · 2020-05-18T19:09:33Z

Test Plan:

follow plan outlined in Additional phase of Brave Ads regions brave-core#4427 for 2-3 new regions above. Each OS should check different regions. (confirmed plan with @jsecretan)
additionally, spot check previously added regions (using google doc list, message me if you need the list) to confirm they are still supported as expected.
"OTHER" country code (as noted in Additional phase of Brave Ads regions #7817 (comment)) is not set up on the server at this time, this is ok for right now.

LaurenWags · 2020-05-19T21:48:03Z

Verified passed using

Brave	1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified the following for new regions (Estonia, Moldova)
- Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default. Confirmed able to view an ad.
- Installed 1.8.96. Enabled Rewards. Confirmed Ads are not available. Upgraded to 1.9.70. Confirmed notification displayed on BAT logo to alert user that ads are now available in their region. Confirmed Ads are not enabled by default on upgrade. Confirmed able to enable ads and view an ad.

Estonia on 1.8.96:

Estonia after upgrade to 1.9.x:

Confirming ad panel updates for Estonia when ads are enabled and an ad notification has been served:

Moldova on 1.8.96:

Moldova after upgrade to 1.9.x:

Confirming ad panel updates for Moldova when ads are enabled and an ad notification has been served:

Also per Additional phase of Brave Ads regions #7817 (comment), spot checked previously enabled ad regions: US, Ireland, Russia and confirmed the following scenarios:
- Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default.
- Installed 1.8.96. Enabled Rewards. Disabled Ads. Upgraded to 1.9.x. Confirmed Ads are still off after upgrade. No notification that ads are available.
- Installed 1.8.96. Enabled Rewards. Upgraded to 1.9.x. Confirmed Ads are still on after upgrade. No notification that ads are available.

Verification passed on

Brave | 1.9.71 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified the following for new regions Iceland and Latvia
- Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default. Confirmed able to view an ad.
- Installed 1.8.96. Enabled Rewards. Confirmed Ads are not available. Upgraded to 1.9.70. Confirmed notification displayed on BAT logo to alert user that ads are now available in their region. Confirmed Ads are not enabled by default on upgrade. Confirmed able to enable ads and view an ad.

Iceland 1.8.96:

Icelanda after upgrade to 1.9.71

Confirming ad panel updates for Iceland when ads are enabled and an ad notification has been served:

Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default. Confirmed able to view an ad.
Installed 1.8.96. Enabled Rewards. Confirmed Ads are not available. Upgraded to 1.9.70. Confirmed notification displayed on BAT logo to alert user that ads are now available in their region. Confirmed Ads are not enabled by default on upgrade. Confirmed able to enable ads and view an ad.

Latvia 1.8.96:

Latvia after upgrade to 1.9.71:

Confirming ad panel updates for Latvia when ads are enabled and an ad notification has been served:

Also per Additional phase of Brave Ads regions #7817 (comment), spot checked previously enabled ad regions: US and India and confirmed the following scenarios:
- Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default.
- Installed 1.8.96. Enabled Rewards. Disabled Ads. Upgraded to 1.9.x. Confirmed Ads are still off after upgrade. No notification that ads are available.
- Installed 1.8.96. Enabled Rewards. Upgraded to 1.9.x. Confirmed Ads are still on after upgrade. No notification that ads are available.

Verification passed on

Brave	1.9.71 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	Ubuntu 18.04 LTS

Verified ads are being enabled after upgrade
Verified ads are enabled on clean install
Verified ability to view an ad
Verified the following regions:

Liechtenstein | LI in 1.8.x

Liechtenstein | LI in 1.9.x

Norway | NO in 1.8.x

Norway | NO in 1.9.x

Luxembourg | LU in 1.8.x

Luxembourg | LU in 1.9.x

Also per #7817 (comment), spot checked previously enabled ad regions: US, Poland. Confirmed the following scenarios:
Clean install of 1.9.x. Enable Rewards. Confirmed Ads are enabled by default.
Installed 1.8.96. Enabled Rewards. Disabled Ads. Upgraded to 1.9.x. Confirmed Ads are still off after upgrade. No notification that ads are available.
Installed 1.8.96. Enabled Rewards. Upgraded to 1.9.x. Confirmed Ads are still on after upgrade. No notification that ads are available.

tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. feature/ads labels Jan 19, 2020

tmancey self-assigned this Jan 19, 2020

tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes enhancement and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 19, 2020

This was referenced Jan 20, 2020

Why am I not seeing Ads? #7236

Closed

Additional phase of Brave Ads regions brave/brave-core#4427

Merged

eljuno mentioned this issue Mar 7, 2020

Consider adding overseas territories as part of supported Brave Ads regions #4347

Closed

tmancey mentioned this issue Mar 24, 2020

Send platform, build channel, and country as part of ad confirmation calls where it meets privacy standards #8100

Closed

tmancey closed this as completed in brave/brave-core#4427 Apr 7, 2020

tmancey added this to the 1.9.x - Nightly milestone Apr 7, 2020

tmancey added the release-notes/include label Apr 7, 2020

GeetaSarvadnya added the QA/Blocked label May 5, 2020

LaurenWags removed the QA/Blocked label May 18, 2020

btlechowski mentioned this issue May 19, 2020

Support UN M49 area codes (which do not contain embargoed countries) in Brave Ads #9134

Closed

LaurenWags added the QA Pass-macOS label May 19, 2020

GeetaSarvadnya added the QA Pass-Win64 label May 20, 2020

btlechowski added the QA Pass-Linux label May 20, 2020

LaurenWags mentioned this issue May 20, 2020

Release Notes for 1.9.x (Release Channel) #9854

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Additional phase of Brave Ads regions #7817

Additional phase of Brave Ads regions #7817

tmancey commented Jan 19, 2020

jwchong commented Mar 10, 2020

eljuno commented Mar 10, 2020

jsecretan commented Mar 24, 2020 •

edited

Loading

GeetaSarvadnya commented May 5, 2020 •

edited

Loading

LaurenWags commented May 18, 2020 •

edited

Loading

LaurenWags commented May 19, 2020 •

edited by btlechowski

Loading

Additional phase of Brave Ads regions #7817

Additional phase of Brave Ads regions #7817

Comments

tmancey commented Jan 19, 2020

jwchong commented Mar 10, 2020

eljuno commented Mar 10, 2020

jsecretan commented Mar 24, 2020 • edited Loading

GeetaSarvadnya commented May 5, 2020 • edited Loading

LaurenWags commented May 18, 2020 • edited Loading

LaurenWags commented May 19, 2020 • edited by btlechowski Loading

jsecretan commented Mar 24, 2020 •

edited

Loading

GeetaSarvadnya commented May 5, 2020 •

edited

Loading

LaurenWags commented May 18, 2020 •

edited

Loading

LaurenWags commented May 19, 2020 •

edited by btlechowski

Loading