Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drop shadows from brave://rewards/ #9450

Closed
jonathansampson opened this issue Apr 24, 2020 · 2 comments · Fixed by brave/brave-core#6765
Closed

Remove drop shadows from brave://rewards/ #9450

jonathansampson opened this issue Apr 24, 2020 · 2 comments · Fixed by brave/brave-core#6765

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Apr 24, 2020

Description

A user on Twitter recently shared the Settings page cards lack drop shadows seen on the Rewards page, even though the two pages share many other style elements.

Steps to Reproduce

Navigate to about:rewards
Navigate to about:settings

Actual result:

Drop shadows present on Rewards page, but not Settings page.

Expected result:

Drop shadows removed from Rewards page.

Reproduces how often:

Always

Brave version (brave://version info)

1.7.98

@jonathansampson jonathansampson added the design A design change, especially one which needs input from the design team label Apr 24, 2020
@karenkliu
Copy link

The issue here is not to add drop shadows to the Settings page; it's to remove drop shadows from the Brave Rewards page.

The design team has standardized our drop shadow treatment so that only UI elements sitting on top of the page, such as menus and modals, will get the drop shadows. In this case the cards on the Brave Rewards page is "Layer 0 Content" so they do not get a drop shadow.

Drop shadows per UI layer defined:
image

@karenkliu karenkliu changed the title Drop shadows missing from Settings Page Remove drop shadows from brave://rewards/ May 1, 2020
@NejcZdovc NejcZdovc removed the design A design change, especially one which needs input from the design team label May 3, 2020
@NejcZdovc NejcZdovc self-assigned this Oct 4, 2020
@NejcZdovc NejcZdovc added this to the 1.17.x - Nightly milestone Oct 4, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Oct 12, 2020

Verified passed with

Brave | 1.17.28 Chromium: 86.0.4240.75 (Official Build) nightly (x86_64)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | macOS Version 10.14.6 (Build 18G3020)

Confirmed no shadows on brave://rewards page with 1.17.x

1.16.x shadows exist 1 16 x 1 1 16 x 2
1.17.x no shadows 1 17 x 1 1 17 x 2

Verification passed on

Brave 1.17.28 Chromium: 86.0.4240.75 (Official Build) nightly (64-bit)
Revision c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS Ubuntu 18.04 LTS

Confirmed no shadows on brave://rewards page with 1.17.x

1.16.x shadows exist
image

1.17.x no shadows
image


Verification passed on

Brave | 1.17.42 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Confirmed no shadows on brave://rewards page with 1.17.x
1.16.x
image
image

1.17.x
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment