Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to enable/disable "tab hover cards" #9906

Closed
Brave-Matt opened this issue May 22, 2020 · 9 comments · Fixed by brave/brave-core#14016
Closed

Add setting to enable/disable "tab hover cards" #9906

Brave-Matt opened this issue May 22, 2020 · 9 comments · Fixed by brave/brave-core#14016
Assignees
Labels
design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/tabs-bar OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@Brave-Matt
Copy link

Brave-Matt commented May 22, 2020

Description

According to #9509, the default "tab hover cards' will revert to the "tooltip" display on-hover. However, the option to display the preview on-hover is still desired by many users (especially those who miss the old tab preview feature from days of old).

We should surface this option from flags to Settings so that users have the choice to display one or the other:
image

Designs

Add toggle for search tabs button to "Appearance" section, above 'Hide search tabs button'

image

Assets

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/?node-id=808%3A9464

@rebron rebron added OS/Desktop feature/global-settings Settings at browser level independent of shields settings labels May 22, 2020
@rebron rebron changed the title Suggestion: Surface "tab hover cards" flag to Settings Surface "tab hover cards" flag to Settings May 22, 2020
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jul 10, 2020
@srirambv srirambv changed the title Surface "tab hover cards" flag to Settings [Desktop] Surface "tab hover cards" flag to Settings Sep 9, 2020
@rebron rebron added the design A design change, especially one which needs input from the design team label May 17, 2021
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels May 17, 2021
@qubetzl
Copy link

qubetzl commented Jun 1, 2021

I've taken a look at the chatter in Chromium's tracker about the recently removed flag for "tab hover cards" - https://bugs.chromium.org/p/chromium/issues/detail?id=1213741

While looking around I stumbled upon the commit that removed the flag and the feature checks about it - https://chromium.googlesource.com/chromium/src/+/e2124a1d261f70ffe0048553b0f4642e0444d6a1

Hope this information is useful for getting the ticket solved.

@alrasch
Copy link

alrasch commented Jun 12, 2021

There used to be a setting to "disable hover cards", but I can no longer find that setting and I'm permanently stuck with the abomination now.

Can it be overridden in Brave despite Chromium's persistence?

@opal1974
Copy link

Yes, this is absolutely distracting and annoying. You used to be able to turn it off in experimental but while the option is still there it does nothing.

@rebron rebron changed the title [Desktop] Surface "tab hover cards" flag to Settings Surface "tab hover cards" flag to Settings Jun 15, 2021
@rebron rebron changed the title Surface "tab hover cards" flag to Settings Add setting to enable/disable "tab hover cards" Jun 25, 2021
@r01k
Copy link

r01k commented Jul 7, 2021

These large tooltips are distracting and cover sections of the URL that often give you the same information to help you differentiate tabs when their title is hidden due to being pinned. The net effect is that they feel annoying.

Please implement a setting to disable them and instead have the previous practical, unobtrusive tooltip.

@adamwinn
Copy link

adamwinn commented Mar 2, 2022

We need a way to disable these. They are so annoying

@vphantom
Copy link

Is there a way we could perhaps have a bounty to fast track this? I'd gladly contribute $100 towards having an option to disable those horrible things entirely in Brave, since the flag is gone.

@stephendonner
Copy link

stephendonner commented Sep 2, 2022

Verification PASSED using

Brave 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (x86_64)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS macOS Version 13.0 (Build 22A5331f)

Steps:

  1. installed 1.44.73
  2. launched Brave
  3. opened abcnews.com
  4. opened bbcnews.com
  5. opened cbsnews.com
  6. hovered over the cbsnews.com tab's title
  7. confirmed a card displaying the the title & origin of the tab popped up after a ~ 1-2 second delay
  8. opened chrome://settings/appearance
  9. confirmed the setting for Tab hover mode was set to Card
  10. changed the setting to Card with preview
  11. hovered over a tab (not the currently active tab)
  12. confirmed a thumbnail and preview of the tab was shown after a ~1-2 second delay
  13. changed the setting to Tooltip
  14. hovered over a tab
  15. confirmed tooltip displaying the site title was displayed
steps 6-7 step 9 step 12 step 15
Screenshot 2022-09-02 at 11 13 03 AM Screenshot 2022-09-02 at 11 16 55 AM Screenshot 2022-09-02 at 11 13 44 AM Screenshot 2022-09-02 at 11 12 47 AM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 2, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 12, 2022

Verification PASSED using

Brave | 1.44.82 Chromium: 105.0.5195.102 (Official Build) beta (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Steps:

  1. installed 1.44.82
  2. launched Brave
  3. visited nytimes.com
  4. visited cnbc.com
  5. visitedbloomberg.com
  6. opened brave://settings/appearance
  7. confirmed 3 options for configuring Tab Hover Mode
    Card
    Card with preview
    Tooltip
  8. confirmed the setting for Tab hover mode was set to Card as a default
  9. hovered over the nytimes.com tab's title
  10. confirmed a card displaying the the title & origin of the tab popped up after a ~ 1-2 second delay
  11. opened brave://settings/appearance
  12. changed the setting to Card with preview
  13. hovered over a tab (not the currently active tab) (cnbc.com)
  14. confirmed a thumbnail and preview of the tab was shown after a ~1-2 second delay
  15. changed the setting to Tooltip
  16. hovered over a tab (bloomberg.com)
  17. confirmed tooltip displaying the site title was displayed
steps 6-8 step9-10 step 11-12 step 13-14 step15 step 16-17
step6-7 step6-7 step6-7 step6-7 step6-7 step6-7

@stephendonner
Copy link

stephendonner commented Sep 16, 2022

Verified PASSED using

Brave 1.44.88 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS Linux

Steps:

  1. installed 1.44.73
  2. launched Brave
  3. opened abcnews.com
  4. opened bbcnews.com
  5. opened cbsnews.com
  6. hovered over the abcnews.com tab's title
  7. confirmed a card displaying the the title & origin of the tab popped up after a ~ 1-2 second delay
  8. opened chrome://settings/appearance
  9. confirmed the setting for Tab hover mode was set to Card
  10. changed the setting to Card with preview
  11. hovered over a tab (not the currently active tab)
  12. confirmed a thumbnail and preview of the tab was shown after a ~1-2 second delay
  13. changed the setting to Tooltip
  14. hovered over a tab
  15. confirmed tooltip displaying the site title was displayed
steps 6-7 step 9 step 12 step 15
Screen Shot 2022-09-16 at 1 21 02 PM Screen Shot 2022-09-16 at 1 15 08 PM Screen Shot 2022-09-16 at 1 25 22 PM Screen Shot 2022-09-16 at 1 25 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/global-settings Settings at browser level independent of shields settings feature/tabs-bar OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.