Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] NTP stats strings are not translated #9990

Closed
btlechowski opened this issue May 28, 2020 · 2 comments
Closed

[Desktop] NTP stats strings are not translated #9990

btlechowski opened this issue May 28, 2020 · 2 comments

Comments

@btlechowski
Copy link

btlechowski commented May 28, 2020

Important: This is regression in 1.10.x.

Steps to Reproduce

  1. Open Brave in PL / JP locale
  2. Open NTP

Actual result:

Ads and trackers blocked, Estimated bandwidth saved and Estimated time saved are not translated

JP - Japanese
image
PL - Polish
image

Expected result:

image
image

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Reproducible on

Brave 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.11.31 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Not reproducible on

Brave 1.9.72 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @brave/legacy_qa @rebron @mkarolin @bsclifton

@btlechowski
Copy link
Author

btlechowski commented Jul 20, 2020

Not reproducible anymore. Verified on 1.12.x

image

@LaurenWags
Copy link
Member

LaurenWags commented Jul 20, 2020

Verified passed with

Brave | 1.12.94 Chromium: 84.0.4147.89 (Oficjalna wersja) dev (64-bitowa)
-- | --
Wersja | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
System operacyjny | macOS Wersja 10.14.6 (kompilacja 18G3020)

Verified Polish and Japanese as per the issue description
Zrzut ekranu 2020-07-20 o 4 34 08 PM

スクリーンショット 2020-07-20 午後4 33 43


Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


Verified Polish and Japanese as per the issue description
image
image

Verification passed on

Brave 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

image
image

@rebron rebron changed the title NTP stats strings are not translated [Desktop] NTP stats strings are not translated Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants