Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "HTTPS Upgrades" stat with "Bandwidth saved" stat #8969

Closed
3 tasks done
rebron opened this issue Apr 1, 2020 · 6 comments · Fixed by brave/brave-core#5437
Closed
3 tasks done

Replace "HTTPS Upgrades" stat with "Bandwidth saved" stat #8969

rebron opened this issue Apr 1, 2020 · 6 comments · Fixed by brave/brave-core#5437
Assignees
Labels
design A design change, especially one which needs input from the design team feature/new-tab l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 1, 2020

Description

Follow-up to #8256 (which added the "Estimated Bandwidth Saved" stat and pushed out the content).

  • Remove HTTPS Upgrades stat and label.
  • Replace with the same formatting and location with stat and "Bandwidth saved" label.
  • Fix sentence casing so it reads "Trackers & ads blocked" and "Time saved"

Actual result:

74566850-46e6b680-4f29-11ea-83a5-a551abc89eb8

Design

replace https with estimated data saved

Reproduces how often:

n/a

Brave version (brave://version info)

n/a

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Check l10n strings for "Estimated Bandwidth Saved" and possible alternate text so that layout flows properly with longer translations.

@rebron rebron added l10n design A design change, especially one which needs input from the design team labels Apr 1, 2020
@rebron
Copy link
Collaborator Author

rebron commented Apr 1, 2020

cc: @bradleyrichter

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Apr 1, 2020
@karenkliu
Copy link

designs added!

@rebron rebron changed the title replace "HTTPS Upgrades" stat with "Estimated Bandwidth Saved" stat replace "HTTPS Upgrades" stat with "Bandwidth saved" stat Apr 3, 2020
@rebron rebron assigned AndriusA and unassigned karenkliu Apr 3, 2020
@rebron
Copy link
Collaborator Author

rebron commented Apr 3, 2020

@AndriusA Can you grab this one?

@rebron rebron added feature/new-tab and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Apr 3, 2020
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 3, 2020
AndriusA pushed a commit to brave/brave-core that referenced this issue May 1, 2020
AndriusA pushed a commit to brave/brave-core that referenced this issue May 4, 2020
AndriusA pushed a commit to brave/brave-core that referenced this issue May 6, 2020
AndriusA pushed a commit to brave/brave-core that referenced this issue May 12, 2020
@bsclifton bsclifton added this to the 1.10.x - Nightly milestone May 12, 2020
@bsclifton
Copy link
Member

Setting missing milestone to 1.10

@btlechowski
Copy link

@rebron I am confused about expected behavior. Should Bandwidth saved stat be shown in 1.10.x?

Right now HTTPS Upgrades is hidden, but Bandwidth saved is not shown:
image

Brave 1.10.71 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

@btlechowski
Copy link

btlechowski commented May 29, 2020

Verification passed on

Brave 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

The stats stings are not translated. Logged #9990
The Estimated bandwidth saved stat is not shown on clean install. Logged #9993

Verified the test plan from the description.
Verified Estimated bandwidth saved stat is shown
image
Verified Estimated bandwidth saved stat is retained after restart

Verification passed on

Brave | 1.10.77 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

clean 1 10 x

  • Confirmed stat also displayed on upgrade (from 1.9.x) profile:

upgrade to 1 10 x

@rebron rebron changed the title replace "HTTPS Upgrades" stat with "Bandwidth saved" stat Replace "HTTPS Upgrades" stat with "Bandwidth saved" stat Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/new-tab l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants