Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable_webtorrent_extension option #2045

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Nov 8, 2018

Add disable_webtorrent_extension option so developers could easily disable webtorrent extension while npm start.

Part of #2043
See also brave/brave-core#832 for brave-core PR.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@yrliou yrliou merged commit 6effbb8 into master Nov 8, 2018
yrliou added a commit that referenced this pull request Nov 8, 2018
Add disable_webtorrent_extension option
@yrliou yrliou deleted the disable_webtorrent_extension branch November 8, 2018 18:28
@yrliou
Copy link
Member Author

yrliou commented Nov 8, 2018

master: 6effbb8
0.58.x: b68572c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants