Fix brave/brave-ios#8585 - Fix Javascript Disabling <NoScript> (brave…

…/brave-ios#8586) - Fix Javascript Disabling not working
brave · Jan 4, 2024 · 3391257 · 3391257
1 parent 73af832
commit 3391257
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/...e/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift b/...e/Frontend/Browser/BrowserViewController/BrowserViewController+WKNavigationDelegate.swift
@@ -380,7 +380,18 @@ extension BrowserViewController: WKNavigationDelegate {
       if let documentTargetURL = documentTargetURL {
         let domainForShields = Domain.getOrCreate(forUrl: documentTargetURL, persistent: !isPrivateBrowsing)
         let isScriptsEnabled = !domainForShields.isShieldExpected(.NoScript, considerAllShieldsOption: true)
+
+        // Due to a bug in iOS WKWebpagePreferences.allowsContentJavaScript does NOT work!
+        // https://github.com/brave/brave-ios/issues/8585
+        //
+        // However, the deprecated API WKWebViewConfiguration.preferences.javaScriptEnabled DOES work!
+        // Even though `configuration` is @NSCopying, somehow this actually updates the preferences LIVE!!
+        // This follows the same behaviour as Safari
+        //
+        // - Brandon T.
+        //
         preferences.allowsContentJavaScript = isScriptsEnabled
+        webView.configuration.preferences.javaScriptEnabled = isScriptsEnabled
       }
 
       // Cookie Blocking code below