Skip to content

Commit

Permalink
Merge pull request #8596 from brave/fix-test-options
Browse files Browse the repository at this point in the history
don't erase the rest of the array when splicing test command lines options
  • Loading branch information
bridiver authored Apr 21, 2021
2 parents cfb3a19 + 9ac7023 commit 3a710ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/commands/lib/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const test = (passthroughArgs, suite, buildConfig = config.defaultBuildConfig, o
// Run the tests
getTestsToRun(config, suite).forEach((testSuite) => {
if (options.output) {
braveArgs.splice(braveArgs.indexOf('--gtest_output=xml:' + options.output, 1))
braveArgs.splice(braveArgs.indexOf('--gtest_output=xml:' + options.output), 1)
braveArgs.push(`--gtest_output=xml:${testSuite}.xml`)
}
if (config.targetOS === 'android') {
Expand Down

0 comments on commit 3a710ed

Please sign in to comment.