Skip to content

Commit

Permalink
Merge pull request #6657 from brave/maxk-hide-safety-check-passwords
Browse files Browse the repository at this point in the history
Settings UI: hides passwords item in Safety Check section.
  • Loading branch information
mkarolin authored Sep 17, 2020
2 parents cee2df1 + b5de348 commit 7445293
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 0 deletions.
1 change: 1 addition & 0 deletions browser/resources/settings/brave_overrides/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import './page_visibility.js'
import './payments_section.js'
import './people_page.js'
import './printing_page.js'
import './safety_check_passwords_child.js'
import './security_page.js'
import './settings_menu.js'
import './settings_section.js'
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Copyright (c) 2020 The Brave Authors. All rights reserved.
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// you can obtain one at http://mozilla.org/MPL/2.0/.

import {RegisterPolymerTemplateModifications} from 'chrome://brave-resources/polymer_overriding.js'

RegisterPolymerTemplateModifications({
'settings-safety-check-passwords-child': (templateContent) => {
const safetyCheckChild = templateContent.getElementById('safetyCheckChild')
if (!safetyCheckChild) {
console.error('[Brave Settings Overrides] Could not find safetyCheckChild id on safety check passwords child page.')
} else {
safetyCheckChild.setAttribute('hidden', 'true')
}
}
})
5 changes: 5 additions & 0 deletions browser/resources/settings/settings_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@
compress="false"
preprocess="true"
type="BINDATA" />
<include name="IDR_SETTINGS_BRAVE_OVERRIDES_SAFETY_CHECK_PASSWORDS_CHILD_JS"
file="brave_overrides/safety_check_passwords_child.js"
compress="false"
preprocess="true"
type="BINDATA" />
<include name="IDR_SETTINGS_BRAVE_OVERRIDES_SECURITY_PAGE_JS"
file="brave_overrides/security_page.js"
compress="false"
Expand Down

0 comments on commit 7445293

Please sign in to comment.