Skip to content

Commit

Permalink
Fixes ad conversion detection fails if the target URL of the last sho…
Browse files Browse the repository at this point in the history
…wn ad matches the conversion URL pattern
  • Loading branch information
tmancey committed Feb 27, 2020
1 parent b19c5b1 commit 839860d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions vendor/bat-native-ads/src/bat/ads/internal/ads_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,8 @@ void AdsImpl::OnPageLoaded(
return;
}

CheckAdConversion(url);

if (DomainsMatch(url, last_shown_notification_info_.url)) {
BLOG(INFO) << "Site visited " << url
<< ", domain matches the last shown ad notification for "
Expand Down Expand Up @@ -735,8 +737,6 @@ void AdsImpl::OnPageLoaded(

CheckEasterEgg(url);

CheckAdConversion(url);

BLOG(INFO) << "Site visited " << url << ", previous tab url was "
<< previous_tab_url_;
}
Expand Down

0 comments on commit 839860d

Please sign in to comment.