Skip to content

Commit

Permalink
Fix brave/brave-ios#8190: Add in-page search to the debug histograms …
Browse files Browse the repository at this point in the history
…controller (brave/brave-ios#8199)
  • Loading branch information
kylehickinson authored Oct 5, 2023
1 parent 73d0f28 commit c28c7c9
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions Sources/Brave/Frontend/Settings/SettingsViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -785,6 +785,22 @@ class SettingsViewController: TableViewController {
let histogramsController = self.p3aUtilities.histogramsController().then {
$0.title = "Histograms (p3a)"
}
if #available(iOS 16.0, *) {
// TODO: Replace this with property access when exposed from brave-core side
let webView = histogramsController.value(forKey: "_webView") as! WKWebView // swiftlint:disable:this force_cast
webView.isFindInteractionEnabled = true
histogramsController.navigationItem.rightBarButtonItem = UIBarButtonItem(
systemItem: .search,
primaryAction: .init { [weak webView] _ in
guard let findInteraction = webView?.findInteraction,
!findInteraction.isFindNavigatorVisible else {
return
}
findInteraction.searchText = ""
findInteraction.presentFindNavigator(showingReplace: false)
}
)
}
self.navigationController?.pushViewController(histogramsController, animated: true)
}, accessory: .disclosureIndicator, cellClass: MultilineValue1Cell.self),
Row(
Expand Down

0 comments on commit c28c7c9

Please sign in to comment.