Skip to content

Commit

Permalink
Merge pull request #3041 from brave/bsc-fix-widevine
Browse files Browse the repository at this point in the history
Fix Widevine issue on macOS introduced with Chromium 76.0.3809.72
  • Loading branch information
bsclifton committed Jul 30, 2019
1 parent 246fefc commit db44c3d
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions patches/chrome-installer-mac-signing-signing.py.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/chrome/installer/mac/signing/signing.py b/chrome/installer/mac/signing/signing.py
index de69f7ba6cca5729ab83ff076211be36354d0f60..63791734d49a77999e446f1083f137e910fbdd8b 100644
index de69f7ba6cca5729ab83ff076211be36354d0f60..875803bff951845a97cb771d445b272113a5ed91 100644
--- a/chrome/installer/mac/signing/signing.py
+++ b/chrome/installer/mac/signing/signing.py
@@ -11,6 +11,7 @@ import os.path
Expand All @@ -10,15 +10,25 @@ index de69f7ba6cca5729ab83ff076211be36354d0f60..63791734d49a77999e446f1083f137e9

_PROVISIONPROFILE_EXT = '.provisionprofile'
_PROVISIONPROFILE_DEST = 'embedded.provisionprofile'
@@ -124,6 +125,7 @@ def get_parts(config):
@@ -76,7 +77,8 @@ def get_parts(config):
'{0.framework_dir}/Helpers/{0.product} Helper.app'.format(
config),
'{}.helper'.format(uncustomized_bundle_id),
- options=full_hardened_runtime_options,
+ options=CodeSignOptions.RESTRICT + CodeSignOptions.KILL +
+ CodeSignOptions.HARDENED_RUNTIME,
verify_options=VerifyOptions.DEEP),
'helper-renderer-app':
CodeSignedProduct(
@@ -124,6 +126,7 @@ def get_parts(config):
library_basename.replace('.dylib', ''),
verify_options=VerifyOptions.DEEP)

+ AddBravePartsForSigning(parts, config)
return parts


@@ -168,7 +170,7 @@ def sign_part(paths, config, part):
@@ -168,7 +171,7 @@ def sign_part(paths, config, part):
part: The |model.CodeSignedProduct| to sign. The product's |path| must
be in |paths.work|.
"""
Expand All @@ -27,7 +37,7 @@ index de69f7ba6cca5729ab83ff076211be36354d0f60..63791734d49a77999e446f1083f137e9
if config.notary_user:
# Assume if the config has notary authentication information that the
# products will be notarized, which requires a secure timestamp.
@@ -260,6 +262,7 @@ def sign_chrome(paths, config, sign_framework=False):
@@ -260,6 +263,7 @@ def sign_chrome(paths, config, sign_framework=False):
continue
sign_part(paths, config, part)

Expand Down

0 comments on commit db44c3d

Please sign in to comment.