Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content_cosmetic.bundle.js multiple injections #10039

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Sep 10, 2021

Resolves brave/brave-browser#17935

This PR split possible multiply calling the whole content_cosmetic.bundle.js to a single injection and multiple calling of the entry point tryScheduleQueuePump().

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@atuchin-m atuchin-m force-pushed the fix-content_cosmetic.bundle.js-multiple-injections branch from 7ff0a8a to d65b244 Compare September 14, 2021 05:31
@atuchin-m atuchin-m added this to the 1.31.x - Nightly milestone Sep 14, 2021
@atuchin-m atuchin-m merged commit f1d6a8c into master Sep 14, 2021
@atuchin-m atuchin-m deleted the fix-content_cosmetic.bundle.js-multiple-injections branch September 14, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize multiple initializations of content_cosmetics.bundle.js during frame load
4 participants