Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert speedreader result prs #10115

Closed
wants to merge 2 commits into from
Closed

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Sep 16, 2021

Resolves brave/brave-browser#18151

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Kevin Kuehler added 2 commits September 15, 2021 16:58
…fix"

This reverts commit 8ffa8d4, reversing
changes made to f1d6a8c.
…esult"

This reverts commit c16968e, reversing
changes made to 5ac6c3b.
@kkuehlz
Copy link
Contributor Author

kkuehlz commented Sep 16, 2021

There is a simple fix for this, but the PR doesn't add any new functionality. I'd prefer to revert for the 1.31.x window and then @iefremov and I can spec out a better and more explicit API for passing around the Speedreader result. That can go in 1.32.x.

@kkuehlz
Copy link
Contributor Author

kkuehlz commented Sep 17, 2021

Closing in favor of #10118

@kkuehlz kkuehlz closed this Sep 17, 2021
@kkuehlz kkuehlz deleted the revert_speedreader_result_prs branch September 17, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speedreader icon not showing up on CR94
1 participant