Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift 1.30.x - fixed download item filename overlap #10121

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Uplift 1.30.x - fixed download item filename overlap #10121

merged 1 commit into from
Sep 17, 2021

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Sep 16, 2021 •
edited
Loading

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Initial PR: #9759
Resolves: brave/brave-browser#17313

The overlap was caused by a recent change we made on the UX of the download item view.
The duped filename was setting itself visible in all modes. There are various modes to take in to consideration however, we only care about the normal mode.

@nullhook nullhook requested a review from a team as a code owner September 16, 2021 16:18
@nullhook nullhook added this to the 1.30.x - Beta milestone Sep 16, 2021
@nullhook nullhook requested a review from a team September 16, 2021 16:20
kjozwiak
kjozwiak approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.30.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9759 (comment).

@kjozwiak kjozwiak merged commit f60fa98 into 1.30.x Sep 17, 2021
@kjozwiak kjozwiak deleted the download-item-text-overlap-1.30.x branch September 17, 2021 06:12
@Tonev Tonev mentioned this pull request Sep 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@nullhook nullhook

Labels
None yet
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@nullhook @kjozwiak