Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Dialog Insight trackers from URLs #12893

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Apr 5, 2022

Resolves brave/brave-browser#22082

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open https://brave.com/?oft_id=946&oft_k=1Enu&oft_lk=kea&oft_d=637.
  2. Check that the URL bar doesn't show any query string parameters (i.e. it should just be brave.com).

@fmarier fmarier requested a review from iefremov as a code owner April 5, 2022 03:59
@fmarier fmarier self-assigned this Apr 5, 2022
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Apr 5, 2022
@fmarier fmarier added this to the 1.39.x - Nightly milestone Apr 5, 2022
@fmarier fmarier merged commit d5c8ed3 into master Apr 6, 2022
@fmarier fmarier deleted the dialog-insight-query-string-22082 branch April 6, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out Dialog Insight trackers from URLs
2 participants