Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Windows standalone installer opened 2 windows (WIP) #13049

Merged

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented Apr 18, 2022

This occurred when the UAC prompt was rejected and Brave was then installed just for the current user.

Resolves brave/brave-browser#22179

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please see brave/brave-browser#22179 for the steps that could be used to reproduce the issue.

For regressions, please test Brave's Standalone installer on Windows. Try both accepting the UAC prompt, to install Brave as admin. And rejecting the UAC prompt, then accepting Yes in the ensuing dialog that asks whether Brave should be installed just for your current user.

This occurred when the UAC prompt was rejected and Brave was then
installed just for the current user.
@mherrmann mherrmann added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 18, 2022
@mherrmann mherrmann requested a review from a team as a code owner April 18, 2022 10:19
@mherrmann mherrmann self-assigned this Apr 18, 2022
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Apr 18, 2022
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unlocking DEPS, should anyone else review this?

@mherrmann
Copy link
Collaborator Author

I'll ask @simonhong once I've done some more testing of the PR build. Thanks @iefremov :-)

@mherrmann mherrmann added this to the 1.39.x - Nightly milestone Apr 19, 2022
@mherrmann mherrmann merged commit fc39311 into master Apr 19, 2022
@mherrmann mherrmann deleted the only-one-browser-window-standalone-installer-nonadmin branch April 19, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Standalone installer: Two browser windows open when installing as non-admin
4 participants