Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve whitespace in signature message text #13254

Closed
wants to merge 1 commit into from

Conversation

devstein
Copy link
Contributor

@devstein devstein commented May 4, 2022

Resolves brave/brave-browser#22699

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Sets `white-space: pre-wrap;` to preserve message text whitespace. This
CSS is consistent with Metamask and Rainbow wallet.
@devstein
Copy link
Contributor Author

Hi 👋 @aseren and @tmancey what's the best way to move this PR forward? This is helpful for SIWE, which is gaining traction.

@bbondy bbondy requested a review from onyb May 27, 2022 15:12
@aseren
Copy link
Collaborator

aseren commented May 27, 2022

Hi 👋 @aseren and @tmancey what's the best way to move this PR forward? This is helpful for SIWE, which is gaining traction.

I think need to request review from @Douglashdaniel, as he is author of this file.

@devstein
Copy link
Contributor Author

Thanks for the quick reply @aseren! I don't have permission to @Douglashdaniel as a reviewer, but looks like @bbondy added @onyb.

@onyb onyb added this to the 1.41.x - Nightly milestone May 30, 2022
@onyb
Copy link
Member

onyb commented May 31, 2022

Merged with #13531. Thanks @devstein for your contribution! 🙌

@onyb onyb closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve Whitespace in Brave Wallet Signing Message Text
3 participants