Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily enable network request from newtab #134

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 5, 2018

close brave/brave-browser#272

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@simonhong simonhong requested review from emerick and bbondy June 5, 2018 11:44
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit d1562fc into master Jun 5, 2018
@simonhong simonhong deleted the enable_network_request_from_newtab branch June 5, 2018 11:52
@bridiver
Copy link
Collaborator

bridiver commented Jun 5, 2018

@simonhong if this is temporary, is there an issue to track the long-term fix?

@simonhong
Copy link
Member Author

@bridiver yep, this - brave/brave-browser#273

@bridiver
Copy link
Collaborator

bridiver commented Jun 5, 2018

Thanks!

NejcZdovc added a commit that referenced this pull request Dec 10, 2018
Add support for direct and recurring donations
NejcZdovc pushed a commit that referenced this pull request Mar 6, 2019
petemill added a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
…tetabtor

Update UI and remove legacy props from private tab page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashed when newtab is loading in C68 debug build
3 participants