Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use chromium's side panel inside our side bar container, and insert Reading List #13769

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Use chromium's side panel inside our side bar container, and insert Reading List #13769

merged 3 commits into from
Aug 22, 2022

Commits on Aug 19, 2022

  1. Use chromium's side panel inside our side bar container, and insert R… 

    …eading List

Chromium's side panel is controlled by Brave's side bar buttons, via chromium's side panel coordinator
    @petemill
    petemill committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    1bb9e9c View commit details
    Browse the repository at this point in the history

  2. sidebar: migrate pref for which built-in items to show from "inclusiv… 

    …e" to "exclusive"

This allows new items to be easily added, and only store the item ref by ID instead of all item details
    @petemill
    petemill committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    54599e7 View commit details
    Browse the repository at this point in the history

  3. Toolbar SidePanel button only opens items added on the sidebar, and h… 

    …ides if none are added
    @petemill
    petemill committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    fd2a6b3 View commit details
    Browse the repository at this point in the history