Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ethereum Ledger integration in untrusted iframe #14373

Merged
merged 1 commit into from
Aug 18, 2022

Commits on Aug 18, 2022

  1. Ledger Ethereum chrome://untrusted refactor

    This change isolates the ledgerjs libraries required to interact with the
    Ethereum app on Ledger devices to an iFrame in a chrome untrusted context.
    It reuses the framework established in the Ledger Solana Ethereum refactor,
    but generalizes some code such that it can be reused for both Solana and
    Ethereum. For example:
    
    * Shared logic in SolanaLedgerBridgeKeyring class has been moved to a new
      parent class that LedgerBridgeKeyring that both SolanaLedgerBridgeKeyring
      and EthereumLedgerBridgeKeyring that both inherit from
    
    * Solana specific logic was moved out of LedgerUntrustedMessagingTransport
      and into a new child class, SolanaLedgerUntrustedMessagingTransport.
      Similarly, Ethereum specific logic is now in a new child class,
      EthereumLedgerUntrustedMessagingTransport that inherits from
      LedgerUntrustedMessagingTransport.
    
    * Common message types were kept in ledger-messages.ts, but Solana and
      Ethereum specific message types were separated into their own
      sol-ledger-messages.ts and eth-ledger-messages.ts modules
      respectively.
    nvonpentz committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    144d32b View commit details
    Browse the repository at this point in the history