Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): Add currency selector for buy tab (uplift to 1.43.x) #14375

Closed
wants to merge 1 commit into from
Closed

feat(wallet): Add currency selector for buy tab (uplift to 1.43.x) #14375

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #14089
Resolves brave/brave-browser#23295

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner July 28, 2022 08:21
@brave-builds brave-builds self-assigned this Jul 28, 2022
@brave-builds brave-builds added this to the 1.43.x - Beta milestone Jul 28, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 28, 2022
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

Closing the above as I don't think this one is urgent enough to get uplifted into 1.43.x. We can let this one ride the trains. @muliswilliam please let me know if you disagree or if this one is needed for other work that might need to go into 1.43.x.

@kjozwiak kjozwiak closed this Jul 28, 2022
@kjozwiak kjozwiak deleted the pr14089_dynamic-currencies-buy-tab_1.43.x branch July 28, 2022 19:14
@kjozwiak kjozwiak removed the request for review from a team July 28, 2022 19:14
@kjozwiak kjozwiak removed the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 28, 2022
@kjozwiak kjozwiak removed this from the 1.43.x - Beta milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases